On Sun, 29.06.14 07:25, Tom Gundersen (tome...@kemper.freedesktop.org) wrote:

> +
> +        FOREACH_WORD(word, len, string, state) {
> +                /* WORD FORMAT: dst_ip/dst_prefixlen,gw_ip */
> +                _cleanup_free_ char* entry;

missing initialization to NULL. 

> +                char *tok, *tok_end;
> +                unsigned n;
> +                int r;
> +
> +                if (!GREEDY_REALLOC(routes, allocated, size + 1))
> +                        return -ENOMEM;
> +
> +                entry = strndup(word, len);

Missing OOM check.

Lennart

-- 
Lennart Poettering, Red Hat
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to