On Mon, Jun 30, 2014 at 02:57:21PM +0200, Lennart Poettering wrote: > On Mon, 30.06.14 14:00, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > > I think I agree with this. The only reason I could think of why this > > > might not be the right thing to do is to be nice to folks who wrote > > > native mount units who want to use the mount option. Because this way > > > the mount option becomes specific to fstab and cannot be used > > > otherwise... (Which actually is exactly what we do for > > > x-systemd.automount, which makes this all feel quite OK) > > > > Good catch. I didn't think about that. Maybe a middle ground of issuing > > a warning? I'll add some code which complains when the option is seen > > in a unit file. > > I'd just document it. I mean, part of the reason for your patch is to > remove this from the core, so it sounds wrong readding this this > way. I'd just document it, and retain no further code for this in PID > 1. Maybe if a thousand bugs get reported about this we can add a > warning, but otherwise I'd really keep this clean. OK, pushed.
Zbyszek _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
