On Fri, Aug 01, 2014 at 06:37:51PM +0300, Samuli Suominen wrote: > On 01/08/14 18:31, Simon McVittie wrote: > > On 01/08/14 15:53, Simon McVittie wrote: > >> Best-practice in Autotools projects seems to be to include config.h at > >> the very top of every .c file, whether it is currently needed or not. > > Sorry, I'd missed that systemd uses "cc -include > > $(top_builddir)/config.h ...", which is even better. My issues with > > btrfs_ioctl_vol_args must have been caused by something else. > > > > nod. I've just tested the original patch I posted, seems to work here... > I suppose it's best to apply the initlal patch first, and see if someone > gets a failed build...
is HAVE_LINUX_BTRFS_H defined for you? I've tried the same thing, and it failed for me, but only with old kernel headers without linux/btrfs.h Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
