Am 27.08.2014 um 20:25 schrieb Ivan Shapovalov: > On Wednesday 27 August 2014 at 20:19:45, Lennart Poettering wrote: >> On Wed, 27.08.14 20:26, Ivan Shapovalov (intelfx...@gmail.com) wrote: >> >>> This is as proposed by Thomas in review of my hibernate-resume patchset. >>> >>> The objective benefit of this change is that in_initrd() function is used >>> for checking, which not only checks for /etc/initrd-release, but also >>> verifies >>> that the rootfs is on a virtual device. >> >> If we add a new condition then I want to hear a strong case for it. I >> mean, what's wrong with checking for initrd-release? Why would that not >> suffice?
Whether or not we are in initrd is what we want to check. The existence of /etc/initrd-release is an implementation detail. Having the same file check as a condition in units duplicates the code that has been implemented in the in_initrd() function. In addition, someone who writes unit files should not be forced to know these implementation details, but should have the proper condition documented for the purpose. That is all there is.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
