On 02/10/14 14:14, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Sep 30, 2014 at 04:24:49PM +0200, Tom Gundersen wrote: >> Hi David, >> >> Just a quick follow up on these two patches (sorry for the delay). >> >> On the one hand, we want this interface to be very basic and should >> probably not something we should extend to cover all sorts of things. >> On the other hand, this usecase (and similar ones where you have a >> real password, but maybe it is a one-time password, so you don't care >> about hiding it) seems very natural, and the patches are simple. >> >> I'll leave it up to Lennart to decide. > > Yes, the patch looks OK, but like with the other one, please > rename do_echo to echo, and add an extra argument to the function instead > of adding a second function.
Thanks a lot for the reviews! I'll submit new patches in the coming days. Just one detail though. When changing the function API, the needed changes will become more intrusive. I tried to keep the change-set as small as possible and preserve a clear use case through the function names. I also feel that the 'echo' flag in password related functions shouldn't be hidden behind a true/false argument to a function, as it is a big difference in the behaviour from a user's perspective. But that is my personal preference. I will do what has been requested in the reviews. -- kind regrards, David Sommerseth _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
