On Mon, Oct 13, 2014 at 03:47:59AM +0200, Zbigniew Jędrzejewski-Szmek wrote:
> On Sun, Oct 12, 2014 at 06:42:36PM -0700, Dave Reisner wrote:
> > src/tmpfiles/tmpfiles.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > New commits:
> > commit e7aab5412829ed6b50d109f670bd0b1b365838a7
> > Author: Dave Reisner <dreis...@archlinux.org>
> > Date: Sat Oct 11 20:35:06 2014 -0400
> >
> > tmpfiles: compare return against correct errno
> >
> > name_to_handle_at returns -EOPNOTSUPP, not -ENOTSUP.
> >
> > diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c
> > index dafb9ae..8108b43 100644
> > --- a/src/tmpfiles/tmpfiles.c
> > +++ b/src/tmpfiles/tmpfiles.c
> > @@ -259,7 +259,7 @@ static int dir_is_mount_point(DIR *d, const char
> > *subdir) {
> >
> > /* got only one handle; assume different mount points if one
> > * of both queries was not supported by the filesystem */
> > - if (r_p == -ENOSYS || r_p == -ENOTSUP || r == -ENOSYS || r ==
> > -ENOTSUP)
> > + if (r_p == -ENOSYS || r_p == -EOPNOTSUPP || r == -ENOSYS || r ==
> > -EOPNOTSUPP)
> > return true;
> They are aliases.
>
> Zbyszek
Hrmm, I had no idea. Thanks for pointing that out.
Anyways, this makes error handling consistent with the other
name_to_handle_at() call in src/shared/path-util.c, which is what
prompted me to be look into this...
d
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
