Hi On Wed, Dec 10, 2014 at 8:00 PM, Torstein Husebø <torst...@huseboe.net> wrote: > Hi, > this patch set inserts missing spaces and newlines in code comments. > No code change. > > Torstein Husebø (6): > networkd/resolved: correct spacing near eol in code comments > sd-bus: correct spacing near eol in code comments > journald: correct spacing near eol code comments > shared: correct spacing near eol in code comments > core: correct spacing near eol in code comments > treewide: correct spacing near eol in code comments
Ok, I went ahead and applied them all. A few notes: 1) Multi-line comments like this are totally ok: /* Some comment with * multiple lines. */ Please don't move the trailing "*/" into a line of itself. It looks assymetrical and is just weird. If the comment starts on the same line as the opening "/*", then the trailing "*/" should be on the same line, too. 2) Please, next time, merge all those patches into a single commit. There is no reason to split them and it just increases the burden on the maintainers. Thanks David > src/core/device.c | 3 ++- > src/core/execute.c | 2 +- > src/core/main.c | 3 ++- > src/core/manager.c | 2 +- > src/core/unit.h | 2 +- > src/hostname/hostnamed.c | 2 +- > src/journal/journal-file.c | 3 ++- > src/journal/journal-verify.c | 3 ++- > src/journal/journald-server.c | 6 +++--- > src/libsystemd-terminal/term-internal.h | 2 +- > src/libsystemd/sd-bus/bus-match.c | 2 +- > src/libsystemd/sd-bus/bus-message.c | 6 +++--- > src/libsystemd/sd-bus/sd-bus.c | 2 +- > src/libsystemd/sd-bus/test-bus-gvariant.c | 2 +- > src/libsystemd/sd-id128/sd-id128.c | 2 +- > src/login/logind-dbus.c | 2 +- > src/network/networkd-address.c | 2 +- > src/network/networkd-netdev.c | 2 +- > src/resolve/resolved-dns-scope.c | 2 +- > src/shared/clock-util.c | 4 ++-- > src/shared/util.c | 6 +++--- > src/systemctl/systemctl.c | 2 +- > src/systemd/sd-login.h | 2 +- > src/test/test-strbuf.c | 2 +- > src/udev/udev-builtin-net_id.c | 2 +- > 25 files changed, 36 insertions(+), 32 deletions(-) > > -- > 2.2.0 > > _______________________________________________ > systemd-devel mailing list > systemd-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/systemd-devel _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel