On Wed, Jan 28, 2015 at 6:04 AM, Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> wrote: > On Wed, Jan 28, 2015 at 03:50:42AM +0100, Lennart Poettering wrote: >> On Wed, 28.01.15 03:47, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) >> wrote: >> >> > On Wed, Jan 28, 2015 at 01:53:17AM +0100, Lennart Poettering wrote: >> > > On Mon, 19.01.15 10:43, Zbigniew Jędrzejewski-Szmek >> > > (zbys...@kemper.freedesktop.org) wrote: >> > > >> > > > src/journal/journalctl.c | 28 ++++++++++++++-------------- >> > > > 1 file changed, 14 insertions(+), 14 deletions(-) >> > > > >> > > > New commits: >> > > > commit 40f0b71b063da6a36b8d7ec75ef20103abd18243 >> > > > Author: Zbigniew J??drzejewski-Szmek <zbys...@in.waw.pl> >> > > > Date: Mon Jan 19 13:42:34 2015 -0500 >> > > > >> > > > journalctl: trim --help to fit in 80 columns >> > > > >> > > > Terminals tend to be 80 columns wide by default, and the help >> > > > text is only supposed to be a terse reminder anyway. >> > > > >> > > >> > > Hmm, maybe we should add a test target to the makefile that runs all >> > > our tools with "--help" and checks that the output it generates is >> > > identical to the output pssed through "fold -w 79" or so? >> > > >> > > (I added this to the TODO list for now) >> > >> > Done. >> >> Hmm, your commit checks for 80 chars, right? Shouldn't we rather check >> for 79? Many terminals that are 80 chars wide will leave one line free >> if you output 80 consecutive chars plus one newline... > Are you sure? I though this was fixed already. > A quick test with the linux console, urxvt, konsole, systemd-subterm, > and xterm all DTRT.
I definitely see it every now and then although I cannot right now tell exactly under which conditions. This could also depend on terminfo entry on particular system. _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
