On Fri, Feb 13, 2015 at 8:51 AM, Martin Pitt <martin.p...@ubuntu.com> wrote: > Martin Pitt [2015-02-12 19:52 +0100]: >> Lennart Poettering [2015-02-12 18:50 +0100]: >> > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=090d25fe224c0 >> > >> > Looks simple enough.
This looks awful. We should not litter generic rules with exotic niche use cases like this. It will end up in a mess. >> >Though I wonder if [0-9] is the right match, >> > shouldn't it also cover multiple numbers there? >> >> Hm, yes. fnmatch() doesn't support a regexp-like "one or more digits"; >> it's less precise, but as the kernel doesn't generate arbitrary device >> names but at most things like "mmcblk0p1", extending the glob to >> mmcblk[0-9]*rpmb is actually safe. > > Pushed now with this change: > > http://cgit.freedesktop.org/systemd/systemd/commit/?id=b87b01c First, what is the use-case for by-path for mmc devices? If there is no strong one, which I suspect, please just remove these rules again. And we should not add more blacklists, especially not "randomly" between multiple rules in the middle of a file. This should be sorted out and be be fixed before the next release. Thanks, Kay _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
