On Tue, 05.05.15 01:15, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote:
> Use strjoina to avoid error handling, and openat to simplify things. > > Some fixes on the way: > - ferror does not set errno, so the return value was wrong in some cases > - errors are propagated in more cases > - EFI/systemd was created, but EFI/systemd-boot was deleted > - something is always printed on error > - when checking the version, comparison was done against "systemd-bo" for > some reason > - install_variables would join paths without "/" which seems wrong > - return value was converted from negative to EXIT_SUCCESS/EXIT_FAILURE twice, > resulting in EXIT_SUCCESS all the time > --- > > This was really only lightly tested, because I don't have suitable > notebook. It would be great if somebody could verify that the > install/uninstall > functionality is not completely broken ;) Go ahead, and commit the three patches, we can fix this if it turns out to be broken after committing. This is new code in systemd anyway, hence it's hardly a regression if it starts out a bit bumpy... Thanks for cleaning this up! Much appreciated! Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
