On 05/29/2015 07:37 PM, Filipe Brandenburger wrote: > I haven't tested it, but I do have a few comments. > > First, why not use "rootlibdir" instead of "rootprefixlibdir"?
Because $(rootlibdir) resolves to /usr/lib64 on my system. [...] > On Fri, May 29, 2015 at 2:05 AM, Daniel Mack <dan...@zonque.org> wrote: >> I had to introduce a new entity in custom-entites.ent, because with >> "--with-rootprefix=/", "&rootprefix;/lib" resolves to "//lib", and with >> the default behaviour of configure, "&rootprefix;lib" becomes "/usrlib". > > Debian is already using --with-rootprefix= (an empty string) exactly > for that reason. > http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/tree/debian/rules#n16 Interesting, thanks for the pointer. > If rootprefix=/, there would be also problems with rootbindir=//bin > and other such definitions getting double slashes. > > Having said that, I do agree that it would be nice to handle > --with-rootprefix=/ correctly without creating double slashes, but I > think it would be preferrable to handle that in general and not for > the specific case of /lib. Yes, the subst logic I added replaces _all_ leading double slashes, and hence avoids touching URLs with "http://". > Perhaps just remove any trailing slashes from rootprefix in > configure.ac instead before generating the Makefile? That would also > handle cases like --with-rootprefix=/usr/ to still generate /usr/bin > and /usr/lib correctly. Yes, that's actually better, you're right. I'll post a patch for this. Thanks, Daniel _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel