Hi, Re: bug 4833 and pull request 4837, https://github.com/systemd/systemd/issues/4833 https://github.com/systemd/systemd/pull/4837
I was thinking of how to add some test cases for whitespace, and keszybz just merged these tests: https://github.com/systemd/systemd/pull/5158 which test for proper whitespace->underscore replacement using $env{}. However, I'd like to also add tests for whitespace replacement using actual device $attr{}, which I think means the test/sys.tar.xz file needs to be updated to add device (maybe a NVMe device) nodes that include whitespace in its model and/or serial strings - is that how new test sysfs device nodes are added? Updating the entire binary seems like a big change just for a few device node files.. Thanks! _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/systemd-devel
