On Tue, Sep 12, 2017 at 2:38 PM, Lennart Poettering <lenn...@poettering.net>
wrote:

> But then, for single-patch PRs we don't do merges but
> rebase+fforward, which github has an explicit button in its UI
> for. But that rebase is kinda broken conceptually by them: it rewrites
> the commits of the PR as a single commit attributed to the person who
> clicked the button, losing all of the original attribution.
>

I think single commit is a different option (squash+merge); using
rebase+merge should still be ok, it keeps the individual commits and only
rewrites the "committer" info.

-- 
Mantas Mikulėnas <graw...@gmail.com>
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to