On Mon, Jan 15, 2018 at 06:44:41PM +0100, Olaf Hering wrote: > I submitted a correct and tested patch via > https://github.com/systemd/systemd/pull/7581, which was using > sscanf("0028f0", "%x",&val). During discussion I was soft-forced to use > systemd helper functions. These (strtoull based) helpers expect "0x...", > which sysfs does not provide. As a result 575e658 is broken. My fault, I did > not doublecheck the updated submission... >
I merged the PR to use sscanf. After all, it works now, it's unlikely for the kernel to change that to something incompatible. Zbyszek > So, how is one supposed to handle untagged hexvalues? Invent a new helper, or > prepend "0x" if missing, or just use sscanf? > > Olaf > _______________________________________________ > systemd-devel mailing list > systemd-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/systemd-devel _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/systemd-devel
