Hi, On Jul 7, 2010, at 10:17 PM, Gerardo Di Iorio wrote:
ok, here comes the review: your use of whitespace became much better, but you still occasionally have excess space in the start and end of lines, as well as in between (double space). I hope I cached all as I committed. I applied most, but not all, see below: > http://www.gerardodiiorio.com > <0001-Add-Parole-media-Player.patch> Committed revision 36759. > <0002-Add-xdg-user-dirs.patch> Committed revision 36760. > <0003-Add-notification-daemon-xfce.patch> Committed revision 36761. > <0004-Slim-fix-build-failure.patch> Committed revision 36762. ( and updated: Committed revision 36765. ) > <0005-Qmail-fix-download-path.patch> I vaguely remember qmail has some esoteric license restriction, such as forbidding mirroring. So not applied. Is there a problem with the original source, or a new version? > <0007-Add-parole-media-player.patch> You already had this as 0001, mixup? > <0008-Add-package-gnonlin.patch> I skipped the duplicate 0007 parole.desc Url tag fixup, and added a .cache from my test build: Committed revision 36765. > <0001-Glibc-add-fgnu89-inline-for-fix-build-failure.patch> With simplifications: Committed revision 36764. Thanks again for your contributions - greetings from the overly sunny Berlin, René -- René Rebe, ExactCODE GmbH, Jaegerstr. 67, DE-10117 Berlin http://exactcode.com | http://t2-project.org | http://rene.rebe.de
----------------------------------------------------------- If you wish to unsubscribe from this mailing, send mail to [email protected] with a subject of: unsubscribe t2
