Hey Toan,

nice to read from you and thank you for the patch.

What kind of problem / symptoms are you fixing with this? I never had issues 
related to glib AFAIR.

Greetings from Berlin,
        René

On Nov 12, 2015, at 23:56, Toan Pham <[email protected]> wrote:

> 
> 
> Glib is a special package that does not like to be optimized by the compiler. 
>  Normally, when compiling glib not inside t2 sandbox, glib build system would 
> be smart enough to check the CFLAGS environment variable and remove the 
> optimization option from there.  However, when building the library with T2 
> and depending if the target is hard configured with command wrapper like 
> "-Os", glib build system wont be able to detect it, which can lead to many 
> expected bugs in glib, particularly gobject, a structured gnome typed object. 
>  The patch below fixes the issue by removing any compiler optimization 
> options from the command wrapper before compiling glib.
> 
> 
> --- package/gnome2/glib/glib.conf.vanilla       2015-11-12 18:52:05.000000000 
> -0500
> +++ package/gnome2/glib/glib.conf       2015-11-12 18:51:09.000000000 -0500
> @@ -12,6 +12,12 @@
>  # GNU General Public License can be found in the file COPYING.
>  # --- T2-COPYRIGHT-NOTE-END ---
> 
> +# Glib does not like to be optimized, t2 gcc wrapper hides optimization
> +# setting from glib which can lead to many strange bugs in glib/gtk.
> +var_remove_regex GCC_WRAPPER_INSERT " " "-O[0-9s]"
> +var_remove_regex SYSGCC_WRAPPER_INSERT " " "-O[0-9s]"
> +var_remove_regex KCC_WRAPPER_INSERT " " "-O[0-9s]"
> +
>  if ! atstage toolchain; then
>         . $base/package/*/*/gnome2-conf.in NO_SANITY_CHECK
> 
> ?

-- 
 ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
 DE Legal: Amtsgericht Berlin (Charlottenburg) HRB 105123B, Tax-ID#: DE251602478
 Managing Director: René Rebe
 http://exactcode.com | http://exactscan.com | http://ocrkit.com | 
http://t2-project.org | http://rene.rebe.de

----------------------------------------------------------- 
If you wish to unsubscribe from this mailing, send mail to
[email protected] with a subject of: unsubscribe t2

Reply via email to