Hi, > On 20. Oct 2023, at 03:14, Siva Mahadevan <m...@svmhdvn.name> wrote: > > Thanks for taking the patch! > > René Rebe wrote: >> So I improved ncurses to not just set prefix, but use our regular auto >> or user set safeguard and fix the ada includes, and objects while at it. > > I think the issue with pkg-config not finding the ncurses .pc file has been > fixed now. However, there are still issues with the combination of ncurses > and readline. > >> I also committed your other changes, including adding the deadline 8.2-001 >> patch: >> Committed revision 65405. >> Committed revision 65406. > > Ah sorry, I missed the patch. However, I'm not sure that readline builds > correctly on a fresh install of t2. Here are my simple repro instructions: > > 1. Fresh install t2-23.10-x86-64-minimal-firefox-gcc-glibc-nocona.iso with > all defaults > 2. Run `svn up` in /usr/src/t2-src (current revision at time of writing is > r65408) > 3. Run `./scripts/Emerge-Pkg readline` to update from 8.1 to 8.2. Notice that > readline builds successfully but gawk fails with "symbol lookup error: > /usr/local/lib/libreadline.so.8: undefined symbol: UP" > 4. Run `ldd /usr/local/lib/libreadline.so.8.2` and notice that ncurses is > *not* linked in it. However, ncurses *is* linked in libreadline.so.8.1, which > is what the ISO comes with.
I noticed something similar last night after my commits. Did this also occur with the state of patches you sent in? > I don't think this is related to the patch of switching to the > "--with-curses" confopt (which I think is the correct one) instead of the > "SHLIB_LIBS=-lncurses" makeopt. I tried reverting just that part back and the > above repro is exactly the same. > >> AFAIC the only changes I did not include is the ncurses png-config tweak, >> please let me know if that is still needed for your build, iwd appears to >> build >> for me. Albei before, and now, too. > > I can definitely continue helping to reproduce any of the build errors I > found. Most of what I've done so far is on a fresh install of t2 gcc+glibc. Thanks and have a great day! René -- ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin http://exactcode.com | http://exactscan.com | http://ocrkit.com
----------------------------------------------------------- If you wish to unsubscribe from this mailing, send mail to li...@t2-project.org with a subject of: unsubscribe t2