Hey,
> On 20. Nov 2023, at 05:59, Siva Mahadevan <[email protected]> wrote:
>
> 7zip now supports linux builds directly in upstream, so move away from
> the (unmaintained) p7zip port. Tested on x86_64 glibc gcc.
Nice!
> TODO:
> * package the special assembler required to build the optimized ASM
> versions
Special assembler? More than n or yasm or so?
> * use the compiler and architecture-specific makefiles when available
>
> P.S. Why is "[DEP] t2-src" in the generated .cache file? I'm leaving it
> here for reference, but I'm guessing it shouldn't be added to the
> submitted .cache file. Is it something wrong with my development
> environment?
Yeah, I had seen this earlier. While this is technically correctly when
building inside the t2-src package, it is superfluous and I currently
manually remove it. We should think if and how we want to automatically
want to filter this.
> +srcdir=CPP/7zip/Bundles/Alone2
> +var_append makeopt ' ' '-f makefile.gcc'
> +makeinstopt=
> +
> +hook_add postmake 3 7zip_postmake
> +
> +7zip_postmake() {
> + install -Dm755 _o/7zz "$root$bindir"/7zz
We don’t usually quote paths like this, and 7zz explicitly at the dest is
superfluos
> + ln -sf 7zz "$root$bindir"/7z
> +}
As I touched the above paths anyway, I sorted this hook after the functions
as we usually try to do for readability in modern code.
Committed revision 65769.
René
--
ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
http://exactcode.com | http://exactscan.com | http://ocrkit.com
-----------------------------------------------------------
If you wish to unsubscribe from this mailing, send mail to
[email protected] with a subject of: unsubscribe t2
