And it was me that had sent Jesse the preEffects stuff (maybe 3 weeks ago) ... I have some changes for it, and I'm also looking for an elegant way to add it to all related tacos components, but if I remember correctly, Jesse had advised to wait for the next release before making any changes.
Regarding preEffects, all its logic can easily end up in a util class which will then be used by AjaxForm/AjaxLinkSubmit/AjaxSubmit/AjaxEventSubmit. I'm also thinking of other approaches, perhaps having an Effectable interface + configuration points in each component where JavascriptRenderers will be contributed. During rendering, all those renderers will get a chance to contribute onclick, or onSomething javascript. This would require a redesign of the components, but ensure 100% reuse. Anyway, for the time being, I can easily implement option 1 unless we decide to postpone everything :) Felix Sun wrote: > I do add popup thing in. :). I am fine for anyone directly point out > my faults, and be happy to accepted it if it is. hehe. > > On 12/18/05, *Jesse Kuhnert* <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > Hehe...I don't think I was trying to target you directly Felix, > perhaps I just forgot who had done what..I think I actually added > the preEffects thing in ;) > > Tests? Yes...I'm not sure about that one either. It's easy to test > components/pages, but components/pages/javascript is an entirely > different matter..I still have high hopes of making htmlunit work > (or, more specifically rhino + htmlunit), but haven't had any free > time lately for pretty much anything. > > Anyway, I wrote a bug report for it so we won't forget. > > > On 12/18/05, *Felix Sun* < [EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > I am sorry for not doing that this release. > a little reason for being delay that in such a long time is I > think that would have room to reduce the duplicated code of > these components. > most common class/method should be introduced for adding such > kinds of feature. that would be unstable for doing that near a > release I think. > > ps. we don't have enough tests for these components, and > sorry, I 'm not very clear on how to write tests of them. > > - Felix > > > On 12/18/05, *Jesse Kuhnert * <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > I finally noticed today the preEffects/popup parameters on > AjaxDirectLink. My memory is malfunctioning too much for > me to remember how much of a hand I had in this, but we > should address it in the next release. > > Basically, there's no good reason why most of these > effects (like preEffects/popup) shouldn't be in almost all > of the action/listener based components. That would > include > AjaxForm/AjaxLinkSubmit/AjaxSubmit/AjaxEventSubmit. It's > probably too late to fix it now, but we should all (myself > included) try as much as possible to think about the other > action/listener components when adding things like this. > It's one of those big items that I think will take away > from the ease of use aspect of things, which we'll have a > hard enough time providing as it is with all the new ajax > concepts floating around. > > my 2 cents.. > > jesse > > > > ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ Tacos-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tacos-devel
