I know :)
It's just that I don't really know 100% what other developers are
currently doing and wanted to inform what i was about to do.
Perhaps someone has already started something similar, or perhaps
someone can propose a different (or more generic) solution.
For instance, I now want to see if similar duplication exists in other
components. It would help if someone already knew the answer.
Jesse Kuhnert wrote:
>P.S. You don't ever need to ask before committing code now, you're a
>committer, use your own judgement ;)
>
>On 2/7/06, Jesse Kuhnert <[EMAIL PROTECTED]> wrote:
>
>
>>Commit away ! sounds great :)
>>
>>On 2/7/06, Andreas Andreou <[EMAIL PROTECTED]> wrote:
>>
>>
>>>After going over some of the components, I have the following
>>>suggestions:
>>>
>>>1) AjaxLinkSubmit outputs an a html tag, but does not use its href
>>>attribute. It does everything
>>>using onclick javascript. Furthermore, the generated href value is of no
>>>
>>>real use, since if javascript
>>>is disabled and the href is indeed used, it throws a StaleLinkException
>>>(cause the other fields of the
>>>form were never submitted and are not present - the AjaxForm that
>>>contains the link expects them).
>>>So, I propose to replace the href value simply with "/" (I tried the
>>>more usual "#" first, but due to the
>>>base tag used in Tapestry 4, it generates a non-existing url). I'm 100%
>>>for this change - we gain 50 bytes
>>>for each AjaxLinkSubmit present in a page and the experience of a user
>>>with no javascript is enhanced.
>>>
>>>2) AjaxDirectLink contains some duplication in the outputted url.
>>>There's one for the href, and there's
>>>the same one to be used in onclick, i.e.
>>>
>>>onclick="javascript:tacos.defaultLinkAction({targetLink: this, url:
>>>'blahblah10moreblahblah', processScripts: .........
>>>
>>>
>>>I propose changing this into
>>>
>>>onclick="javascript:tacos.defaultLinkAction({targetLink: this, url:
>>>this.href, processScripts: .........
>>>
>>>and also leaving out the "javascript:" part (it's only required in an
>>>href attribute, it is assumed in the onclick).
>>>
>>>Doing this for EffectsExample produces a 18KB lighter html page!!! The
>>>Tree component also benefits from this.
>>>
>>>I'm also 100% for this change (having checked the tests and seeing them
>>>all pass), so i'm just waiting for
>>>your opinion / objections before commiting them.
>>>
>>>
>>>
>>>
>>>
>>>
>>>-------------------------------------------------------
>>>This SF.net email is sponsored by: Splunk Inc. Do you grep through log
>>>files
>>>for problems? Stop! Download the new AJAX search engine that makes
>>>searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
>>>http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
>>>
>>>_______________________________________________
>>>Tacos-devel mailing list
>>>[email protected]
>>>https://lists.sourceforge.net/lists/listinfo/tacos-devel
>>>
>>>
>>>
>>
>>
>
>
>
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Tacos-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tacos-devel
