This breaks tacos:Table
The correct fix as already stated is
writer.attribute("id", cycle.getUniqueId (getIdParameter()));
and it's already in the CVS.Andrea Chiumenti wrote: > Hi, I locally modified the source code to obtain the desired id: > -------------------------------------------------------------------------- > > Index: AjaxDirectLink.java > =================================================================== > RCS file: > /cvsroot/tacos/tacos4/src/java/net/sf/tacos/ajax/components/Attic/AjaxDirectLink.java,v > retrieving revision 1.25.2.10 <http://1.25.2.10> > diff -u -r1.25.2.10 AjaxDirectLink.java > --- AjaxDirectLink.java 23 Mar 2006 17:24:42 -0000 1.25.2.10 > <http://1.25.2.10> > +++ AjaxDirectLink.java 29 Mar 2006 12:38:38 -0000 > @@ -95,7 +95,8 @@ > > EffectStringUtils.createPreEffectsScript(getPreEffects(), > getUpdateComponents()) > + getLinkString(cycle, false) > + "; return false;"); > - writer.attribute("id", getIdPath()); > + String id = > (getIdParameter()!=null)?getIdParameter():getIdPath(); > + writer.attribute("id", id); > } > } > > > Index: AjaxDirectLink.jwc > =================================================================== > RCS file: > /cvsroot/tacos/tacos4/src/java/net/sf/tacos/ajax/components/Attic/AjaxDirectLink.jwc,v > retrieving revision 1.13.2.5 <http://1.13.2.5> > diff -u -r1.13.2.5 AjaxDirectLink.jwc > --- AjaxDirectLink.jwc 23 Mar 2006 17:24:42 -0000 1.13.2.5 > <http://1.13.2.5> > +++ AjaxDirectLink.jwc 29 Mar 2006 12:39:25 -0000 > @@ -98,7 +98,7 @@ > > <parameter name="disabled" /> > > - <parameter name="id" property="idParameter" default-value="id"/> > + <parameter name="id" property="idParameter" /><!-- > default-value="id"/--> > > <parameter name="anchor" /> > > > > I hope this can work for you too! > > Regards, > kiuma > > On 3/28/06, *Cosmin Bucur* <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > Why wouldn't it work to leave the user overwrite the id when needed ? > > On 3/28/06, Andreas Andreou <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > That's exactly why i started this thread. > > The change i proposed would render > > id="deleteLink" or id="deleteLink_0" or id="deleteLink_1" or ... > > > > However, your actual problem is that there's no correct way to > get the > > rendered id of an AjaxDirectLink. > > > > Perhaps we can add a getClientId method, so that you can do > > "ognl:components.myAjaxDirectLink.clientId" without needing to know > > how tacos is actually generating the id, be it > > 'userDetailComponent.$AjaxDirectLink_1' or simply 'deleteLink' > > > > > > > > Andrea Chiumenti wrote: > > > > > My problem is that with the current implementation this > > > <a jwcid="@tacos:AjaxDirectLink" > > > listener="ognl:deleteLinkListener" > > > updateComponents="ognl:updateComponents" > > > clientScriptEnabled="ognl:true" > > > processScripts="ognl:processScripts" > > > parameters="ognl:user.id <http://user.id> > <http://user.id>" > > > class="formButtons" > > > id="deleteLink"> > > > <span jwcid="@Insert" value="message:delete" > > > > column > > > </span> > > > </a> > > > > > > is rendered like : > > > > > ><a > > href="/CEDI/ajaxdirect.svc?component=userDetailComponent.%24AjaxDirectLink_1&page=users%3AFindUsers&rand=-1386035430&session=T&sp=l1&updatedirect=false&updateid=userDetail" > > > >processscripts="true" > > >clientscriptenabled="true" > > > > > >class="formButtons" > > >onclick="tacos.defaultLinkAction({targetLink: this, url: > > >this.href, processScripts: true}); return false;" > > >id= > > >"userDetailComponent.$AjaxDirectLink_1"> > > > Elimina > > ></a> > > > > > > Regards, > > > kiuma > > > > > > On 3/28/06, *Andreas Andreou* <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]> > > > <mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>> wrote: > > > > > > I'm still waiting for Leo's opinion on this, but you'll > > > probably be able to do this in beta-2. > > > > > > BUT you must understand that it will NOT always work. > > > > > > For instance, if you create a custom component that > includes an > > > AjaxDirectLink and uses (somewhere) > > > ognl:components.myAjaxDirectLink.id > <http://components.myAjaxDirectLink.id> > > > <http://components.myAjaxDirectLink.id> > > > < http://components.myAjaxDirectLink.id > > > > and then put this custom component in a page twice > > > > > > > > > Andrea Chiumenti wrote: > > > > > > > Yes if i can specify the id there is no problem, but in > the nightly > > > > build if I remember I couldn't. > > > > Thx, > > > > kiuma > > > > > > > > On 3/28/06, *Andreas Andreou* <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]> > > > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> > > > > <mailto: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>> wrote: > > > > > > > > getId() breaks in loops and in components within > components. > > > > > > > > And afaik, ognl:components.myAjaxDirectLink.id > <http://components.myAjaxDirectLink.id> > > > <http://components.myAjaxDirectLink.id > <http://components.myAjaxDirectLink.id>> > > > > < http://components.myAjaxDirectLink.id> is no > better than > > > simply > > > > literal:myAjaxDirectLink ( or > literal:myAjaxDirectLinkId if > > > you've > > > > specified an id) > > > > > > > > But i'm sure Leonardo knows more about all these :) > > > > > > > > Andrea Chiumenti wrote: > > > > > > > > > if you don't use the default id given by getId() > I'm not > > > able to > > > > > reference the component in > > > > > Tapestry-ognl using notation > > > > "ognl: components.myAjaxDirectLink.id > <http://components.myAjaxDirectLink.id> > > > <http://components.myAjaxDirectLink.id> > > > > < http://components.myAjaxDirectLink.id> > > > > > < http://components.myAjaxDirectLink.id > > > > <http://components.myAjaxDirectLink.id>>" > > > > > > > > > > On 3/28/06, *Andrea Chiumenti* < [EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]> > > > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> > > > > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>> > > > > > <mailto: [EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]> <mailto:[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> > > > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>>> wrote: > > > > > > > > > > why not to use getId() ? > > > > > > > > > > > > > > > On 3/28/06, *Cosmin Bucur * > <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > > > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> > > > > <mailto:[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]> <mailto:[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>>> > > > > > <mailto:[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]> <mailto:[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> > > > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>>> wrote: > > > > > > > > > > I guess this answers the questions i was > shooting > > > in the bug > > > > > tracking "device" > > > > > > > > > > On 3/28/06, Andreas Andreou < > [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > > > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> > > > > <mailto: [EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]> <mailto:[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>>> > > > > > <mailto:[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]> > > > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > > > <mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>>>> > > > > wrote: > > > > >> Leonardo + others, > > > > >> in a recent change of AjaxDirectLink, we added: > > > > >> writer.attribute("id", getIdPath()); > > > > >> Previously we used: > > > > >> writer.attribute("id", getIdParameter()); > > > > >> > > > > >> Neither of those generate unique ids. > > > > >> The first tries to solve the 'multiple AjaxTables > in page' > > > > > problem > > > > >> but the second produces ids closer to the ones > specified by > > > > > users. > > > > >> > > > > >> The next try achieves both: > > > > >> writer.attribute("id", cycle.getUniqueId > (getIdParameter())); > > > > >> > > > > >> comments? problems? > > > > >> > > > > >> Is AjaxTable the only component that uses the id of > > > > > AjaxDirectLink? > > > > >> > > > > >> > > > > >> > ------------------------------------------------------- > > > > >> This SF.Net email is sponsored by xPML, a > groundbreaking > > > > > scripting language > > > > >> that extends applications into web and mobile > media. Attend > > > > > the live webcast > > > > >> and join the prime developer group breaking into > this new > > > > > coding territory! > > > > >> > > > > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> > > > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642>> > > > > > > > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> > > > < > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642>>> > > > > > > > > > > > > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> > > > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642>> > > > > > > > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> > > > < > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642>>>> > > > > >> _______________________________________________ > > > > >> Tacos-devel mailing list > > > > >> [email protected] > <mailto:[email protected]> > > > <mailto: [email protected] > <mailto:[email protected]>> > > > > <mailto: [email protected] > <mailto:[email protected]> > > > <mailto: [email protected] > <mailto:[email protected]>>> > > > > > <mailto:[email protected] > <mailto:[email protected]> > > > <mailto:[email protected] > <mailto:[email protected]>> > > > > <mailto: [email protected] > <mailto:[email protected]> > > > <mailto:[email protected] > <mailto:[email protected]>>>> > > > > >> > https://lists.sourceforge.net/lists/listinfo/tacos-devel > > > > > < > > > https://lists.sourceforge.net/lists/listinfo/tacos-devel> > > > > >> > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > > This SF.Net email is sponsored by xPML, a > > > groundbreaking > > > > > scripting language > > > > > that extends applications into web and mobile > > > media. Attend > > > > > the live webcast > > > > > and join the prime developer group > breaking into > > > this new > > > > > coding territory! > > > > > > > > > > > > > http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642 > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642> > > > > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642 > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642>> > > > > > > > > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642 > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642> > > > < > http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642 > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642>>> > > > > > < > > > > > > > > http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642 > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642> > > > > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642 > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642>> > > > > < > > > > http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642 > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642> > > > < > http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642 > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642>>>> > > > > > > _______________________________________________ > > > > > Tacos-devel mailing list > > > > > [email protected] > <mailto:[email protected]> > > > <mailto:[email protected] > <mailto:[email protected]>> > > > > <mailto: [email protected] > <mailto:[email protected]> > > > <mailto:[email protected] > <mailto:[email protected]>>> > > > > > <mailto: [email protected] > <mailto:[email protected]> > > > <mailto:[email protected] > <mailto:[email protected]>> > > > > <mailto: [email protected] > <mailto:[email protected]> > > > <mailto:[email protected] > <mailto:[email protected]>>>> > > > > > > > > https://lists.sourceforge.net/lists/listinfo/tacos-devel > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > This SF.Net email is sponsored by xPML, a > groundbreaking > > > scripting > > > > language > > > > that extends applications into web and mobile media. > Attend the > > > > live webcast > > > > and join the prime developer group breaking into > this new > > > coding > > > > territory! > > > > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> > > > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642>> > > > > > > > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> > > > < > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642>>> > > > > _______________________________________________ > > > > Tacos-devel mailing list > > > > [email protected] > <mailto:[email protected]> > > > <mailto: [email protected] > <mailto:[email protected]>> > > > > <mailto:[email protected] > <mailto:[email protected]> > > > <mailto: [email protected] > <mailto:[email protected]>>> > > > > https://lists.sourceforge.net/lists/listinfo/tacos-devel > > > > < > https://lists.sourceforge.net/lists/listinfo/tacos-devel> > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > This SF.Net email is sponsored by xPML, a groundbreaking > scripting > > > language > > > that extends applications into web and mobile media. > Attend the > > > live webcast > > > and join the prime developer group breaking into this new > coding > > > territory! > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> > > > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642>> > > > _______________________________________________ > > > Tacos-devel mailing list > > > [email protected] > <mailto:[email protected]> > > > <mailto:[email protected] > <mailto:[email protected]>> > > > https://lists.sourceforge.net/lists/listinfo/tacos-devel > <https://lists.sourceforge.net/lists/listinfo/tacos-devel> > > > > > > > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by xPML, a groundbreaking > scripting language > > that extends applications into web and mobile media. Attend the > live webcast > > and join the prime developer group breaking into this new coding > territory! > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > <http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> > > _______________________________________________ > > Tacos-devel mailing list > > [email protected] > <mailto:[email protected]> > > https://lists.sourceforge.net/lists/listinfo/tacos-devel > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting > language > that extends applications into web and mobile media. Attend the > live webcast > and join the prime developer group breaking into this new coding > territory! > http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642 > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642> > _______________________________________________ > Tacos-devel mailing list > [email protected] > <mailto:[email protected]> > https://lists.sourceforge.net/lists/listinfo/tacos-devel > > ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ Tacos-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tacos-devel
