Porting the code across was my first code review of some of the code, so it isn't entirely perfect, just yet. I have the team making some changes now, and I hope to find time review them and commit them later this week. All of our components now exist exclusively in tacos, so I will no longer have to port them back and forth. I will merely have to review and copy their changes to my code tree so that I can commit them.
We will be modifying accordion and tabs so that you can define ContentPane components within them instead of as entirely separate divs. That will make it possible to do things like create tabs and accordion panes in a loop. That is the only large change that is in the works. We've also got dojo title pane and dojo combo box widgets coming over sometime soon. This is particularly useful because the scriptaculous autocompleter is incompatible with dojo tabs (and probably accordion or anything else that uses content pane). Dojo combo box should offer the same functionality in a more compatible form. It will also act as a more sophisticated drop down select list than is offfered by plain html. --sam On 5/30/06, Andreas Andreou <[EMAIL PROTECTED]> wrote:
good choice :) though, i didn't get any commit emails... anyone else got them? Sam Gendler wrote: > I committed to the trunk. Afterall, what's revision control for if > you can't roll back a commit that someone doesn't like. I have tested > it well, in any case, and I am confident that the new code works. No > older code was affected at all, so all should be well. > > --sam > > > On 5/30/06, Sam Gendler <[EMAIL PROTECTED]> wrote: >> I have a number of new components added to tacos and demo pages to go >> with them. They aren't perfect, but they do work. Should I check >> into a branch or the trunk? >> >> components are - tooltip, slider, tabs, accordion, and updated grid >> >> --sam >> > > > ------------------------------------------------------- > All the advantages of Linux Managed Hosting--Without the Cost and Risk! > Fully trained technicians. The highest number of Red Hat > certifications in > the hosting industry. Fanatical Support. Click to learn more > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 > _______________________________________________ > Tacos-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/tacos-devel > ------------------------------------------------------- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 _______________________________________________ Tacos-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tacos-devel
------------------------------------------------------- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 _______________________________________________ Tacos-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tacos-devel
