andyhot wrote: > ok, so, I took another look, and... > I agree with the noasync related code changes, so, i'll merge that in soon > (so as we have it in the 4.1.1 release) > > I'm happy you agree on the core problem this was addressing. I've seen the patch is now conflicting with recent DojoWidget changes if you want I can provide a new patch for it.
Don't know if you were planning to merge exactly my prototype code but in fact I do see a problem there in how the noasync listener url is generated: the way it is in my code would probably work 99% of the time but to be consistent with Tapestry way of generating links/urls this would require an on purpose ServiceEncoder or even a specific IEngine that would be almost equal to DirectServiceEngine apart from the fact that would have to store/retrieve the daojo event name in some special attribute/parameter. In fact it seems a bit too much for such a simple thing but this is the tapestry way as far as I understand. What do you think? > Also, I'm in favor of changing the event connection that DojoWidget does > so that when you specify callback:fn > > it generates > > dojo.event.connect(Widget, "onClick", fn); > > instead of the current > dojo.event.connect(Widget, "onClick", "fn"); > > This will make it even easier to use (see previous email in this thread) > > Anyone sees any problems with that? > > great, but wouldn't be clearer callback:inline ? If you like I can also provide code for this simple thing ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Tacos-devel mailing list Tacos-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tacos-devel
