Mark Femal wrote:
> 
> Hi Glenn (et. al.)
> 
> Started to use the Jakarta datetime lib and wanted to suggest a few
> improvements (nothing earth-shattering here, just some small suggestions):
> 
> 1.  Addition of a "date" and "defaultText" attribute:
>     date = used for formatting (overrides tag body)
>     defaultText = if NumberFormatException when parsing body or date ==
> null this is the text used for defaults
> 
> The above allows you to significantly cut down on the amount of code for
> formatting (i.e. you can do something like this:
>         <td width="50%">Last Unsuccessful Login:</td>
>         <td width="50%">
>         <dt:format pattern="M-d-yyyy 'at' hh:mm:ss zzz"
>                    defaultText="&nbsp;"
>                    date="<%= bean.getLastBadLoginDate() %>" />
>         </td>
> 
> rather than checking to see if lastBadLoginDate == null explicitly and
> also having a default format -- especially useful for table and formatting
> based on data obtained via data sources.
> 
> 2.  Adjustments to tld:  (ADD)
> 
>         <attribute>
>             <name>date</name>
>             <required>false</required>
>             <rtexprvalue>true</rtexprvalue>
>         </attribute>
>         <attribute>
>             <name>defaultText</name>
>             <required>false</required>
>             <rtexprvalue>false</rtexprvalue>
>         </attribute>
> 
> excellent work BTW on the taglib!  I'll have more suggestions maybe
> later...
> 

I have implemented your changes (slightly modifed).

Thanks Mark.

Regards,

Glenn

----------------------------------------------------------------------
Glenn Nielsen             [EMAIL PROTECTED] | /* Spelin donut madder    |
MOREnet System Programming               |  * if iz ina coment.      |
Missouri Research and Education Network  |  */                       |
----------------------------------------------------------------------

Reply via email to