Greetings, I'm new to the Taglib mailing lists, so apologies in advance if this post disregards any established protocol. While attempting to incorporate the I18N taglib into a JSR-168 portlet deployed onto BEA WebLogic 8.1 SP3 I consistently encountered NullPointerExceptions in MessageTag.java at line 190. I suspect the WebLogic portlet container is to blame for the goofiness, but a small patch remedied the issue quite nicely. Attached is the CVS diff -u, if one of the committers could review and apply it I would be most appreciative.
Regards, Jonathan Anderson Booz Allen Hamilton
? diff.txt Index: src/org/apache/taglibs/i18n/MessageTag.java =================================================================== RCS file: /home/cvspublic/jakarta-taglibs/i18n/src/org/apache/taglibs/i18n/MessageTag.java,v retrieving revision 1.9 diff -u -r1.9 MessageTag.java --- src/org/apache/taglibs/i18n/MessageTag.java 4 Jun 2004 04:35:44 -0000 1.9 +++ src/org/apache/taglibs/i18n/MessageTag.java 13 Sep 2004 18:54:48 -0000 @@ -1,18 +1,18 @@ /* * Copyright 1999,2004 The Apache Software Foundation. - * + * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. - */ + */ package org.apache.taglibs.i18n; @@ -156,7 +156,10 @@ public final void release() { super.release(); - _arguments.clear(); + if (_arguments != null) + { + _arguments.clear(); + } _key = null; _value = null; _bundle = null; @@ -187,7 +190,9 @@ } // Reset the arguments - _arguments.clear(); + if (_arguments != null) { + _arguments.clear(); + } if ( _args != null ) { _arguments.addAll(Arrays.asList(_args)); }
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
