[EMAIL PROTECTED] ha scritto:
This patch is now fixed so as not to try os.path.normpath() when the module is
None.  If that was the reason that you unpulled it, lelit, then now you can
repull it.


Oh, I see that this was not the reason.  In fact, self.module is None at this 
point.  Shouldn't the repository object be fully initialized, including its 
self.module member, before _validateConfiguration is called?

I'm about to push a much simpler test against module=='.', that may be enough.

Your approach is both wrong and probably excessive; 1) only the svn repository has this need, as other may even not know about "module" (in other words, you wanted to augment SvnRepository._validateConfiguration(), not the generic Repository's one; 2) you cannot use normpath or the like, as it does the wrong thing: svn paths use forward slashes, always, as they are URLs after all, while normpath (and os.sep and os.extsep) are obviously using the host os habit.

I'm sorry I did not explain better the problem with your first submission.

ciao, lele.
_______________________________________________
Tailor mailing list
[email protected]
http://lists.zooko.com/mailman/listinfo/tailor

Reply via email to