On Wednesday, 21 June 2006 at 01:07, Lele Gaifax wrote: > Brendan Cully wrote: > >Tue Jun 20 13:31:36 PDT 2006 Brendan Cully <[EMAIL PROTECTED]> > > * [hg] Use high level commit command > > > > commands.commit takes care of expanding directories to their component > > files so we don't have to (we weren't doing it correctly either). If > > mercurial ever decides to track directories, this will already be > > correct. > > > >Tue Jun 20 14:08:28 PDT 2006 Brendan Cully <[EMAIL PROTECTED]> > > * [hg] Remove files under subdirectories > > > > removePathnames was just ignoring directories instead of > > removing the files under them. Tailor should walk mercurial's > > dirstate and remove all files under a removed directory. > > > > Hi Brendan, thank you for keeping the HG backend up to the task! > > Do these patches fix #62? They seem to collide with the patch on the > ticket. Did you see that one? I'd give the precedence to yours, but I'd > like to have an explicit +1, since I cannot easily understand some > little differences (why thomas' one does some check for RENAMED entries)?
Hi Lele, These patches also solve #62 in my testing (I put a note on the ticket about that). I was able to avoid doing the explicit checks for RENAMED/REMOVED entries in the commitEntries hook by using the higher level commands.commit hg function (the same function called by the command line interface). It already knows how to translate directory arguments into the entities mercurial actually tracks. I like these patches a little better than the one on #62, because they aren't as low-level.
pgp1ghgNdVfqr.pgp
Description: PGP signature
_______________________________________________ Tailor mailing list [email protected] http://lists.zooko.com/mailman/listinfo/tailor
