K.S.Sreeram wrote:
I had assumed that only moves are reported with wrong ordering by darcs
changes. Unfortunately it looks like poor ordering can be reported for
other types of changes too.

for example, in tailor's repo, see the following patch:
HASH=20060702232916-130f5-728038e54e0a59bb3567d8aa170610c2eaf370ff.gz
darcs changes --xml --summary --matches "hash $HASH"

Here's the relevant portion of the output (de-xmled):

move  : vcpx/repository/git/core.py -> vcpx/repository/git/__init__.py
modify: vcpx/repository/git/__init__.py
add   : vcpx/repository/git/core.py

Here the ordering is completely screwed up!! The right ordering should
be 'add', 'move', and then 'modify'! Note that the relative ordering of
the 'add' and 'modify' is wrong too.

Yes, I know :-( I had to do dirty tricks in tailor too, to workaround to this issue. There's already an open ticket on darcs, for some unknown reason it prefers starting with moves hunks in patch external representation (even if internally the order is obviously right).


I've updated the trac-darcs code for handling bad-ordering to be more
generic, and it now works with the tailor repo.


Great, thanks, pulling :)

ciao, lele.

_______________________________________________
Tailor mailing list
[email protected]
http://lists.zooko.com/mailman/listinfo/tailor

Reply via email to