-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Bob Tanner wrote:
> $ bzr --version > Bazaar (bzr) 0.9.0dev0 > bzr checkout, revision 1910 > nick: bzr.dev > revid: [EMAIL PROTECTED] > Using python interpreter: /usr/bin/python2.4 > Using python standard library: /usr/lib/python2.4 > Using bzrlib: /home/tanner/projects/bazaar-ng/bzr.dev/bzrlib > > And a 'darcs pull' of tailor as of 08/08/2006. Here are a couple of comments from the bzr developers. Aaron Bentley <[EMAIL PROTECTED]> It looks as though you have a commit hook that is a plugin, and Tailor isn't causing plugins to be loaded, so your commit hook can't execute. In bzr itself, we provide the ability to run without plugins loaded, so you'd presumably get the same failure from "bzr --no-plugins commit". I guess the questions are: 1. should we fail or warn if the commit hook can't execute? 2. should we load plugins by default, or should we require Tailor to do that? John Arbash Meinel <[EMAIL PROTECTED]> This seems like someone has installed a post-commit hook, which is trying to use a plugin (like the post-email commit hook). And Tailor is importing 'bzrlib', but not importing bzrlib.plugin.load_plugins(). So the commit code is trying to grab the post-commit function which is configured in ~/.bazaar/bazaar.conf, which tells it to look for bzrlib.plugins.email.... Anyway, there are several possible fixes: 1) Have them remove the post-commit plugin from ~/.bazaar/bazaar.conf (or maybe even locations.conf). The user can do this already. And they probably don't want to send an email for each tailor conversion anyway. 2) Tailor should probably be calling bzrlib.plugin.load_plugins() 3) We need better handling of when a post-commit action cannot be performed. none of these are mutually exclusive. - -- Bob Tanner <[EMAIL PROTECTED]> | Phone : (952)943-8700 http://www.real-time.com, Minnesota, Linux | Fax : (952)943-8500 Key fingerprint = AB15 0BDF BCDE 4369 5B42 1973 7CF1 A709 2CC1 B288 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQFE2P+XfPGnCSzBsogRAnAhAJ9xucu2JqRXeG2EuH8zCQZJbIqsqQCfRoQu xHyhLMr7F3CojJTSK8A7hUw= =wEQn -----END PGP SIGNATURE----- _______________________________________________ Tailor mailing list [email protected] http://lists.zooko.com/mailman/listinfo/tailor
