#167: perforce stacktrace on empty rev['notes']
----------------------------+-----------------------------------------------
Reporter: vincent.legoll | Owner: lele
Type: defect | Status: new
Priority: major | Milestone: VersionOne
Component: tailor | Version: 0.9
Keywords: |
----------------------------+-----------------------------------------------
Tracker for the bug (& patch) reported earlier on ML:
http://lists.zooko.com/pipermail/tailor/2008-August/001362.html
---------------------------------------------------------------
I was testing P4 -> svn migration and found a bug in tailor
It gave me a stack trace with:
"IndexError: list index out of range"
because there was no 'notes' element in a given revision output from a
"p4 filelog" command
The changelist which made tailor::p4 choke was a complex merge
(~1300 lines of p4 diff) with manual conflict resolution
The attached patch fixed (at least the symptom (crash)) for me and the
migration continued
smoothly...
Could you review the patch and commit it, if it is good enough ?
Let me know of any problems with it or my submission of it.
(Should I submit a request in trac ?)
2008-08-06 14:49:41 CRITICAL: Upstream change application failed
2008-08-06 14:49:41 CRITICAL: Something unexpected!
Traceback (most recent call last):
File "/home/vince/bin/tailor-0.9.35/vcpx/tailor.py", line 154, in
__call__
self.update()
File "/home/vince/bin/tailor-0.9.35/vcpx/tailor.py", line 118, in update
applyable=self._applyable, applied=self._applied)
File "/home/vince/bin/tailor-0.9.35/vcpx/dualwd.py", line 102, in
applyPendingChangesets
applied=applied)
File "/home/vince/bin/tailor-0.9.35/vcpx/source.py", line 113, in
applyPendingChangesets
res = self._applyChangeset(c)
File "/home/vince/bin/tailor-0.9.35/vcpx/repository/p4/source.py",
line 108, in _applyChangeset
note = log[0]['revs'][0]['notes'][0]
IndexError: list index out of range
--
Ticket URL: <http://progetti.arstecnica.it/tailor/ticket/167>
Tailor <http://progetti.arstecnica.it/tailor>
An inter-VCs changeset exchanger
_______________________________________________
Tailor mailing list
[email protected]
http://lists.zooko.com/mailman/listinfo/tailor
