On Sun, 15 Feb 2009 22:22:47 -0600 Erik Purins <[email protected]> wrote:
> I was trying to setup tailor on windows to do a perforce->svn setup, > and the error I was getting didn't make any sense. > > In p4lib.py, the windows command line that is passed to popen3 has > every element (command and arg in argv) as single quoted. > > When you run the command in a windows cmd prompt, it looks like and > returns this: > > - ---------- > H:\erik>'p4.exe' '-c' 'tailor' '-p' 'localhost:1666' 'changes' > '//local/web/eta.org/IWOJIMA/home/shaggy/public_html/...' > > ''p4.exe'' is not recognized as an internal or external command, > operable program or batch file. > - ---------- > > If I hack the _run method to look something like this, it gets by. > ... > Is there a better way to fix this? I didn't write that piece, and actually I never used p4, so I'm sorry to see that the coding style of the p4lib is so different from the other backends... The best approach would be eliminating all the references to "os.popen3" and "popen2.Popen3" replacing that code with shwrap.py classes, like other backends do, that already hide windows particularities. In particular, "_escapeArg()", "_joinArgv()" and "_run()" definitions should go away, and "_run()" calls replaced by a single call to "ExternalCommand(blabla).execute()". > I'm trying to open a trac issue, but it says my permissions are > currently limited. You need to be acknowledged, just send me your account please. ciao, lele. -- nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia. [email protected] | -- Fortunato Depero, 1929. _______________________________________________ Tailor mailing list [email protected] http://lists.zooko.com/mailman/listinfo/tailor
