Argh. Extremely sorry, accidentally clicked the send button before completing the email. Retrying:
Thanks for the reply :) I only tested the logic of the line that I wrote in ipython, I didn't run a "real" test. If this isn't good enough I completely understand and will come back with confirmation ASAP after a real test. Is there any documentation on how to import my add my patched liveusb-creator into the ISO? Or should I just mount ISO as loopback and apply the patch there? As far as the output goes, seems like a good idea to me, I was just trying to make it a "one liner" ;) On 26 September 2013 23:52, Sina S <[email protected]> wrote: > Thanks for the reply :) > > I only tested the logic of the line that I wrote in ipython, I didn't run > a "real" test. If this isn't good enough I completely understand and will > come back with confirmation ASAP after a real test. Is there any > documentation on how to > > As far as the output goes, seems like a good idea to me, > > > On 26 September 2013 22:19, intrigeri <[email protected]> wrote: > >> Hi, >> >> Sina S wrote (26 Sep 2013 06:18:05 GMT) : >> > Here is my first patch attempt, submitted by email as suggested by the >> > website. >> >> Thanks for this patch, and thanks a lot for caring about our preferred >> way to receive and review patches. This is much appreciated. >> >> > Feedback appreciated. >> >> Here we go. >> >> > + if not src.lower().endswith('.iso'): shutil.copy(src, >> dst) >> >> Assuming you've tested this and it works fine, the only comment I have >> is that we might want to output a debug message (print >> sys.stderr) >> such as: >> >> Skipping FILENAME.iso... >> >> If you think it's overkill, I probably wouldn't disagree. >> >> Waiting for your confirmation that it was tested, and then I'm happy >> to test and merge this patch :) >> >> Cheers, >> -- >> intrigeri >> | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc >> | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc >> _______________________________________________ >> tails-dev mailing list >> [email protected] >> https://mailman.boum.org/listinfo/tails-dev >> > >
_______________________________________________ tails-dev mailing list [email protected] https://mailman.boum.org/listinfo/tails-dev
