Hi, Alan wrote (11 Oct 2013 17:52:19 GMT) : >> Just curious: any specific reason that I've missed to display the >> device size in the confirmation dialog on initial install, but not at >> upgrade time? >> > No.
Do you intend to fix this (say, in time for 0.22), or should I? >> _("You are going to install Tails on the %(vendor)s %(model)s >> device (%(size)s). " "All data on the selected drive will be lost. " >> "Continue?") >> > I'm afraid that the phrasing make the suer believe that her data is > actually erased, which is not the case, but that's not a regression. I'm not afraid about it, but point taken. If you care, feel free to file a ticket and/or propose another phrasing :) >> > +def _format_bytes(value): >> > + return '%0.1f GB' % (value / 10.0**9) >> >> I appreciate the minor refactoring, but then I'd rather: >> >> * either use some library to display human-readable units in all >> cases (think: 2TB external drive) to improve UX >> * or simply rename the function to _format_bytes_in_GB, so that at >> least the name expresses its current limitations. >> > I would choose the 2nd for now. Do you intend to fix this (say, in time for 0.22), or should I? >> However, the No/Yes buttons ordering seems unusual to me. I didn't >> dare patching it, as I thought you might have followed the GNOME HIG >> or something, and I may be missing something. Any reason to order it >> this way? >> > No. I'm used to GTK+, which chooses the right order automatically. Qt > might not do that. Do you intend to fix this (say, in time for 0.22), or should I? >> The device choice menu doesn't fit, and has an ugly "go down" button >> when I: >> 1. start the GUI with only one possible device plugged in >> 2. plug a second device >> 3. open the menu >> It's not as painful to use as the greeter language menu, but still. >> I can't reproduce this is the target device is plugged before I start >> the installer. Can you reproduce this? > I'll have a look. Thanks. >> To end with, the test suite was not updated yet, and is likely broken >> by these changes, so please file a ticket about it, assigned to me if >> you wish (I'd rather do it together, though). This must be fixed >> before the 0.21 freeze. >> > I'm afraid that I don't have the infrastructure to do that yet, so I > would appreciate if you took care of it. OK, will (try to) do. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc _______________________________________________ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev