Hi,
[email protected] wrote (06 Dec 2013 21:11:53 GMT) :
> See my tails repository, branch "import-translations-extern".
> It includes the required updates to the release process documentation too.
> This works good too, and is without the code duplication.
> So merge this one if you like this one better.
> In my whisperback repository, branch "import-translations-extern",
> there is a commit that belong to these changes.
I do like this one better :)
Here's an initial code review.
Instead of:
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
.. I would write the slightly nicer (to my eye):
SCRIPT_DIR=$(readlink -f $(dirname "$0"))
Regarding:
> - $GIT_IN_TOR_TRANSLATION_DIR fetch origin
> + eval "$GIT_IN_TOR_TRANSLATION_DIR fetch origin"
... why the need to use "eval" here?
Same for:
> + eval "$AFTER_IMPORT"
... where:
$AFTER_IMPORT
would work, right?
Once these small concerns of mine are cleared, I'm happy to merge this
branch.
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
_______________________________________________
tails-dev mailing list
[email protected]
https://mailman.boum.org/listinfo/tails-dev
