Alan:
> Hi,
> 
>> my first little patch :)
> 
> Thanks for your contribution.
> 
>> Tested on Tails 1.0.
>>
> I'm afraid you didn't test exactly that. I had to change search_column
> from 0 to 1.

Indeed :)))

> Anyway that's a minor think that I changed, but I had to amend your
> commit and thus change its id. Test passes in 1.1~rc1 and it's now
> merged in greeter's master.
> 
> For next time when you assign a ticket to a reviewer please set "QA
> check" to "Ready for QA"

Ok.

> If you are interested on tackling a slightly more complicated task in
> the same field you might be interested by:
> 
> - #5760: tails-greeter: feedback when repairing damaged persistent
>   filesystem (Python/Gtk)
> - #5502: Notify user if hardware requirements are not met

Thanks for the pointers,
u.
_______________________________________________
Tails-dev mailing list
[email protected]
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
[email protected].

Reply via email to