intrigeri:
> anonym:
>> IMHO those of us with access to jenkins should also make sure to
>> check the tests before asking for a review. Clearly I failed at that
>> this time (but I have done it at other times, so it was just a slip!),
>> so the blame is on me, really! :S
>
> Feel free to add this to our branch submission checklist :)
Done in commit 31898c6.
> Still, between a branch submission and when it's reviewed, things may
> change and break, so IMO the burden of checking test suite results
> should primarily lie on the gatekeeper, that is the person who makes
> the decision of merging or not.
Of course, like I said ("also") this is just an additional check, now to
not waste the reviewer's time in case your modification actually breaks
a test.
Cheers!
_______________________________________________
Tails-dev mailing list
[email protected]
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to
[email protected].
