On Mon, Dec 15, 2008 at 8:04 PM, Till Harbaum / Lists <[email protected]> wrote:
> So the question is: This has started as a mobile editor with focus on small
> devices and ease of use. Do you think there's enough demand for yet another
> desktop editor to also support binary distributions for desktop linux
> machines?
It certainly looks very promising. I downloaded 0.6 and tried it out
and found some minor problems, most/all of which you're probably aware
of.
* The toolbar items don't have any tooltips - I've attached a patch
that fixes this which you may or may not want to use as-is
* When I select a way and try to add a node to a way I can't add a
node where osm2go renders a direction arrow
* It can't handle GPX tracks with multiple embedded tracks ("ignoring
additional track"). This applies to pretty much all of my tracks
* There are no shortcut keys for anything - or maybe there are and
they only work on the nokia device. On the desktop it would be pretty
neat to have "a" for add node, "w" for way, "p" for split way etc etc.
The property dialog has the same problem
But it certainly has potential. Most of the issues I listed are minor
UI issues which are easy to fix and the core looks to be good, and
it's fast & snappy.
diff --git a/iconbar.c b/iconbar.c
index 38fd4f9..686de63 100644
--- a/iconbar.c
+++ b/iconbar.c
@@ -168,12 +168,15 @@ GtkWidget *icon_add(GtkWidget *vbox, appdata_t *appdata,
}
static GtkWidget *tool_add(GtkWidget *toolbar, appdata_t *appdata,
- char *icon_str,
+ char *icon_str,
+ char *tooltip_str,
void(*func)(GtkButton*, gpointer)) {
GtkWidget *item =
GTK_WIDGET(gtk_tool_button_new(
icon_widget_load(&appdata->icon, icon_str), NULL));
+ gtk_widget_set_tooltip_text(item, tooltip_str);
+
if(func)
gtk_signal_connect(GTK_OBJECT(item), "clicked",
(GtkSignalFunc)func, appdata);
@@ -195,39 +198,39 @@ GtkWidget *iconbar_new(appdata_t *appdata) {
gtk_toolbar_set_style(GTK_TOOLBAR(iconbar->toolbar), GTK_TOOLBAR_ICONS);
/* -------------------------------------------------------- */
- iconbar->trash = tool_add(iconbar->toolbar, appdata,
- "trash", on_trash_clicked);
+ iconbar->trash = tool_add(iconbar->toolbar, appdata,
+ "trash", "Delete item", on_trash_clicked);
/* -------------------------------------------------------- */
gtk_toolbar_insert(GTK_TOOLBAR(iconbar->toolbar),
gtk_separator_tool_item_new(),-1);
- iconbar->info = tool_add(iconbar->toolbar, appdata, "info", on_info_clicked);
+ iconbar->info = tool_add(iconbar->toolbar, appdata, "info", _("Properties"), on_info_clicked);
/* -------------------------------------------------------- */
gtk_toolbar_insert(GTK_TOOLBAR(iconbar->toolbar),
gtk_separator_tool_item_new(),-1);
- iconbar->node_add = tool_add(iconbar->toolbar, appdata, "node_add",
+ iconbar->node_add = tool_add(iconbar->toolbar, appdata, "node_add", _("Add node"),
on_node_add_clicked);
/* -------------------------------------------------------- */
gtk_toolbar_insert(GTK_TOOLBAR(iconbar->toolbar),
gtk_separator_tool_item_new(),-1);
- iconbar->way_add = tool_add(iconbar->toolbar, appdata, "way_add",
+ iconbar->way_add = tool_add(iconbar->toolbar, appdata, "way_add", _("Add way"),
on_way_add_clicked);
- iconbar->way_node_add = tool_add(iconbar->toolbar, appdata, "way_node_add",
+ iconbar->way_node_add = tool_add(iconbar->toolbar, appdata, "way_node_add", _("Add a node to a way"),
on_way_node_add_clicked);
- iconbar->way_cut = tool_add(iconbar->toolbar, appdata, "way_cut",
+ iconbar->way_cut = tool_add(iconbar->toolbar, appdata, "way_cut", _("Split way at a given node"),
on_way_cut_clicked);
- iconbar->way_reverse = tool_add(iconbar->toolbar, appdata, "way_reverse",
+ iconbar->way_reverse = tool_add(iconbar->toolbar, appdata, "way_reverse", _("Reverse way"),
on_way_reverse_clicked);
/* -------------------------------------------------------- */
gtk_toolbar_insert(GTK_TOOLBAR(iconbar->toolbar),
gtk_separator_tool_item_new(),-1);
- iconbar->relation_add = tool_add(iconbar->toolbar, appdata, "relation_add",
+ iconbar->relation_add = tool_add(iconbar->toolbar, appdata, "relation_add", _("Add relation"),
on_relation_add_clicked);
gtk_box_pack_start(GTK_BOX(vbox), iconbar->toolbar, TRUE, TRUE, 0);
_______________________________________________
talk mailing list
[email protected]
http://lists.openstreetmap.org/listinfo/talk
