Hello, I agree the idea and thank you for doing the operation, can you highlight on the wiki the key and the logic ? it seem to be key : website url source (but not contact:website heritage:website brand:website source:website operator:website was:website ?) target : "fbclid", "gclid", "campaign_ref", "mc_id", "utm_source", "utm_medium", "utm_term", "utm_content", "utm_campaign"
someone who doesn't read the code, must still be able to easily understand the criteria of the operation. Regards, Marc Le 13.05.20 à 13:40, Mateusz Konieczny via talk a écrit : > URL often have unnecessary parts, typically added for tracking purposes. > This tracking parameters sshould never appear in any osm tags. > > FB, Google and other add tracking links for various purposes. > > It means that it is beneficial to turn tag > website=http://paris.intersquat.org/les-lieux/le-satellite/?fbclid=de58e340d6aa79a584552a2055042d004b9b19454bc0d7a6046fc81fc90f51 > into > website=http://paris.intersquat.org/les-lieux/le-satellite/ > > This urls can be often fixed using an automated script, allowing to > use human time on something more productive. > > Human-made edit will also result in changing "last edited by" > (while not allowing to filter out such edits unlike marked bot edit), > there are better ways to spot areas requiring fixes and we are not lacking > places with QA indicators that manual review is needed. > > Usually tracking links are added by clueless people who just searched for > a website and copied it from FB/Google. > > There are rare cases of links created to specifically track OSM users > see for example > * https://www.openstreetmap.org/way/754704241/history > ** https://www.cronauerlaw.com/?utm_source=openstreetmap > * https://www.openstreetmap.org/node/1063808111/history > ** > http://www.travelerscoffee.ru?utm_campaign=geo&utm_source=openstreetmap&utm_medium=link > * https://www.openstreetmap.org/node/6817678019/history > ** > https://www.resotainer.fr/agence-bonneuil-sur-marne?utm_source=open-street-map&utm_medium=recherche-locale&utm_content=openstreetmap&utm_campaign=open-street-map-garde-meubles-bonneuil-sur-marne > * https://www.openstreetmap.org/node/1684317522 > ** > http://www.travelerscoffee.ru?utm_campaign=geo&utm_source=openstreetmap&utm_medium=link > > In general I have not noticed correlation between presence of tracking links > and additional issues that would not be detected automatically. > > Therefore automatic removal of tracking parameters is not causing loss of > useful indicators of areas that should be reviewed. > Osmose and JOSM validators and StreetComplete are offering better > indicators. > > Automatic removal would allow me to spend time on something more useful, > than reviewing all cases where this links are present and confirming > them one by one. > > Proposed bot edit would remove links where all used parameters are tracking > users and may be removed. Other links will be reviewed manually to catch > also currently unknown tracking parameters. > > Anchors (#section) will be preserved. > > Parameters for removal across OSM: fbclid, gclid, campaign_ref, mc_id, > utm_source, utm_medium, utm_term, utm_content, utm_campaign > > Code is tested, I am currently using it in a manual review mode. > Sole difference in but run will be disabling of manual confirmation. > > I have experience with automated edits, see > https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account > > Yes, editing element will cause it to be edited and change "last edited" > date. > Effect will be exactly the same in case of using bot and manual edit > (which I will do anyway in case of rejecting this automated edit proposal). > Note that in case of bot edits you may filter out bot edits marked as > automatic. > > Documentation page: > https://wiki.openstreetmap.org/wiki/Mechanical_Edits/Mateusz_Konieczny_-_bot_account/remove_tracking_parameters > > Edits that would be made by bot, based on currently present tracking > parameters: > https://gist.github.com/matkoniecz/6710d066fea6596533f5013040eb5dc1 > > _______________________________________________ > talk mailing list > [email protected] > https://lists.openstreetmap.org/listinfo/talk > _______________________________________________ talk mailing list [email protected] https://lists.openstreetmap.org/listinfo/talk
