I like it, thanks a lot! Three more remarks: * the JavaDoc of SerializableAdaptor is no longer accurate. * the JavaDoc of SqueezeAdaptor still contains tags for IOExceptions. * you might want to remove DataSqueezerImpl.isPrefixRegistered()
Markus On 8/10/05, Howard M. Lewis Ship (JIRA) <[email protected]> wrote: > [ http://issues.apache.org/jira/browse/TAPESTRY-541?page=all ] > > Howard M. Lewis Ship closed TAPESTRY-541: > ----------------------------------------- > > Fix Version: 4.0 > Resolution: Fixed > > Thanks for the patch; I did a bit of moving around. Also, there was no good > reason for the majority of the adaptors to be services, ordinary instances > were fine. The SerializableAdaptor was a good candidate for a service, since > it needs a ClassResolver injected in (it used to get it from the > DataSqueezer). I was able to simplify many APIs, removing "throws > IOException" (throwing ApplicationRuntimeException is more useful) from the > various method signatures. > > I also re-tooled the SerializableAdapter; Make use of the > org.apache.commons.codec.binary.Base64 codec, and to try both uncompressed > and gzip compressed versions (keeping the shorter of the two). That means > that simple Serializable objects will encode much smaller than in the past > (since the compression overhead is not universally applied). > > > Add a configuration point for creating additional SqueezeAdaptors > > ----------------------------------------------------------------- > > > > Key: TAPESTRY-541 > > URL: http://issues.apache.org/jira/browse/TAPESTRY-541 > > Project: Tapestry > > Type: New Feature > > Components: Framework > > Versions: 4.0 > > Reporter: Howard M. Lewis Ship > > Assignee: Howard M. Lewis Ship > > Fix For: 4.0 > > > > > A configuration point is needed so that additional squeeze adaptors (as > > instance, or occasionally as services) can be created. This will allow > > applications to more seamlessly encode data into hidden fields or URLs. > > -- > This message is automatically generated by JIRA. > - > If you think it was sent incorrectly contact one of the administrators: > http://issues.apache.org/jira/secure/Administrators.jspa > - > For more information on JIRA, see: > http://www.atlassian.com/software/jira > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Always remember you're unique. Just like everyone else. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
