Author: hlship
Date: Mon Aug 29 14:35:16 2005
New Revision: 264642
URL: http://svn.apache.org/viewcvs?rev=264642&view=rev
Log:
TAPESTRY-611: Pattern validator invokes wrong client-side JavaScript function
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/validator/Pattern.java
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/validator/TestPattern.java
jakarta/tapestry/trunk/status.xml
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/validator/Pattern.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/validator/Pattern.java?rev=264642&r1=264641&r2=264642&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/validator/Pattern.java
(original)
+++
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/validator/Pattern.java
Mon Aug 29 14:35:16 2005
@@ -77,7 +77,7 @@
String pattern = _matcher.getEscapedPatternString(_pattern);
String message = buildMessage(context, field);
- StringBuffer buffer = new StringBuffer("function(event) {
Tapestry.validate_regexp(event, '");
+ StringBuffer buffer = new StringBuffer("function(event) {
Tapestry.validate_regex(event, '");
buffer.append(field.getClientId());
buffer.append("', '");
buffer.append(pattern);
Modified:
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/validator/TestPattern.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/validator/TestPattern.java?rev=264642&r1=264641&r2=264642&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/validator/TestPattern.java
(original)
+++
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/validator/TestPattern.java
Mon Aug 29 14:35:16 2005
@@ -117,7 +117,7 @@
{ "Fred" }, "default message");
context
- .addSubmitHandler("function(event) {
Tapestry.validate_regexp(event, 'myfield', '"
+ .addSubmitHandler("function(event) {
Tapestry.validate_regex(event, 'myfield', '"
+ pattern + "', 'default message'); }");
replayControls();
@@ -152,7 +152,7 @@
"custom\\message");
context
- .addSubmitHandler("function(event) {
Tapestry.validate_regexp(event, 'myfield', '"
+ .addSubmitHandler("function(event) {
Tapestry.validate_regex(event, 'myfield', '"
+ pattern + "', 'custom\\\\message'); }");
replayControls();
Modified: jakarta/tapestry/trunk/status.xml
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/status.xml?rev=264642&r1=264641&r2=264642&view=diff
==============================================================================
--- jakarta/tapestry/trunk/status.xml (original)
+++ jakarta/tapestry/trunk/status.xml Mon Aug 29 14:35:16 2005
@@ -52,6 +52,7 @@
<changes>
<release version="4.0-beta-6" date="unreleased">
<action type="update" dev="HLS" due-to="Henri Yandell">Convert Tapestry
repository from CVS to SVN</action>
+ <action type="fix" dev="HLS" fixes-bug="TAPESTRY-611">Pattern validator
invokes wrong client-side JavaScript function</action>
</release>
<release version="4.0-beta-5" date="Aug 26 2005">
<action type="fix" dev="MB,HLS" fixes-bug="TAPESTRY-552">Improperly
configured SerializableAdaptor (for DataSqueezer) prevents serialized objects
from being de-serialized</action>
@@ -410,6 +411,10 @@
</release>
</changes>
<votes>
+ <vote title="Tapestry 4.0-beta-5" date="Aug 26 2005">
+ <motion> Release early; release often. Lots of good fixes here, and I
like releasing a beta every week or so. </motion>
+ <response> HLS, PF, MB, RLS, GL, HK, DS: +1 </response>
+ </vote>
<vote title="Tapestry 4.0-beta-4" date="Aug 9 2005">
<motion>
Since we've found and fixed a couple of real show-stopper bugs in
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
