Author: hlship
Date: Fri Sep 9 05:43:14 2005
New Revision: 279756
URL: http://svn.apache.org/viewcvs?rev=279756&view=rev
Log:
TAPESTRY-583: Spurious ERROR message (probably should be WARN or INFO) when
template does not refer to components in page spec
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/pageload/PageLoader.java
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/resolver/ComponentSpecificationResolverImpl.java
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ComponentTemplateLoaderLogic.java
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/pageload/TestPageLoader.java
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/resolver/TestComponentSpecificationResolver.java
jakarta/tapestry/trunk/status.xml
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/pageload/PageLoader.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/pageload/PageLoader.java?rev=279756&r1=279755&r2=279756&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/pageload/PageLoader.java
(original)
+++
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/pageload/PageLoader.java
Fri Sep 9 05:43:14 2005
@@ -251,14 +251,14 @@
{
if (!name.equals(parameterName))
{
- _log.error(PageloadMessages.usedParameterAlias(
+ _log.warn(PageloadMessages.usedParameterAlias(
contained,
name,
parameterName,
bspec.getLocation()));
}
else if (pspec.isDeprecated())
- _log.error(PageloadMessages.deprecatedParameter(
+ _log.warn(PageloadMessages.deprecatedParameter(
name,
bspec.getLocation(),
contained.getType()));
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/resolver/ComponentSpecificationResolverImpl.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/resolver/ComponentSpecificationResolverImpl.java?rev=279756&r1=279755&r2=279756&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/resolver/ComponentSpecificationResolverImpl.java
(original)
+++
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/resolver/ComponentSpecificationResolverImpl.java
Fri Sep 9 05:43:14 2005
@@ -107,7 +107,7 @@
IComponentSpecification spec = getSpecification();
if (spec.isDeprecated())
- _log.error(ResolverMessages.componentIsDeprecated(type, location));
+ _log.warn(ResolverMessages.componentIsDeprecated(type, location));
}
/**
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ComponentTemplateLoaderLogic.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ComponentTemplateLoaderLogic.java?rev=279756&r1=279755&r2=279756&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ComponentTemplateLoaderLogic.java
(original)
+++
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ComponentTemplateLoaderLogic.java
Fri Sep 9 05:43:14 2005
@@ -281,7 +281,7 @@
String parameterName = pspec == null ? attributeName :
pspec.getParameterName();
if (!attributeName.equals(parameterName))
- _log.error(ImplMessages.usedTemplateParameterAlias(
+ _log.warn(ImplMessages.usedTemplateParameterAlias(
token,
attributeName,
parameterName));
@@ -422,7 +422,7 @@
ids = new HashSet(ids);
ids.removeAll(_seenIds);
- _log.error(ImplMessages.missingComponentSpec(_loadComponent, ids));
+ _log.warn(ImplMessages.missingComponentSpec(_loadComponent, ids));
}
Modified:
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/pageload/TestPageLoader.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/pageload/TestPageLoader.java?rev=279756&r1=279755&r2=279756&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/pageload/TestPageLoader.java
(original)
+++
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/pageload/TestPageLoader.java
Fri Sep 9 05:43:14 2005
@@ -128,7 +128,7 @@
Log log = (Log) newMock(Log.class);
log
- .error("Parameter barney (for component FredComponent, at
classpath:/org/apache/tapestry/pageload/TestPageLoader, line 1) was bound; this
parameter has been deprecated, bind parameter fred instead.");
+ .warn("Parameter barney (for component FredComponent, at
classpath:/org/apache/tapestry/pageload/TestPageLoader, line 1) was bound; this
parameter has been deprecated, bind parameter fred instead.");
IBinding binding = newBinding();
MockControl sourcec = newControl(BindingSource.class);
@@ -185,7 +185,7 @@
Log log = (Log) newMock(Log.class);
log
- .error("Parameter fred (at
classpath:/org/apache/tapestry/pageload/TestPageLoader, line 1) has been
deprecated, "
+ .warn("Parameter fred (at
classpath:/org/apache/tapestry/pageload/TestPageLoader, line 1) has been
deprecated, "
+ "and may be removed in a future release. Consult the
documentation for component FredComponent to "
+ "determine an appropriate replacement.");
Modified:
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/resolver/TestComponentSpecificationResolver.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/resolver/TestComponentSpecificationResolver.java?rev=279756&r1=279755&r2=279756&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/resolver/TestComponentSpecificationResolver.java
(original)
+++
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/resolver/TestComponentSpecificationResolver.java
Fri Sep 9 05:43:14 2005
@@ -129,7 +129,7 @@
Log log = (Log) newMock(Log.class);
log
- .error("Component 'MyComponent' (at
classpath:/org/apache/tapestry/resolver/TestComponentSpecificationResolver,
line 1) is deprecated, and will likely be removed in a later release. Consult
its documentation to find a replacement component.");
+ .warn("Component 'MyComponent' (at
classpath:/org/apache/tapestry/resolver/TestComponentSpecificationResolver,
line 1) is deprecated, and will likely be removed in a later release. Consult
its documentation to find a replacement component.");
replayControls();
Modified: jakarta/tapestry/trunk/status.xml
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/status.xml?rev=279756&r1=279755&r2=279756&view=diff
==============================================================================
--- jakarta/tapestry/trunk/status.xml (original)
+++ jakarta/tapestry/trunk/status.xml Fri Sep 9 05:43:14 2005
@@ -52,7 +52,8 @@
<changes>
<release version="4.0-beta-7" date="unreleased">
<action type="fix" dev="HLS" fixes-bug="TAPESTRY-341">Report location of
errors initializing managed beans</action>
- <action type="fix" dev="HLS" fixes-bug="TAPESTRY-270" due-to="Andy
Hedges">FAQ Code example contains bug</action>
+ <action type="fix" dev="HLS" fixes-bug="TAPESTRY-270" due-to="Andy
Hedges">FAQ Code example contains bug</action>
+ <action type="fix" dev="HLS" fixes-bug="TAPESTRY-583">Spurious ERROR
message (probably should be WARN or INFO) when template does not refer to
components in page spec</action>
</release>
<release version="4.0-beta-6" date="Sep 7 2005">
<action type="update" dev="HLS" due-to="Henri Yandell">Convert Tapestry
repository from CVS to SVN</action>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
