Author: hlship
Date: Fri Sep 9 13:48:44 2005
New Revision: 279874
URL: http://svn.apache.org/viewcvs?rev=279874&view=rev
Log:
Remove IComponent.getComponent() (added in 4.0)
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/AbstractComponent.java
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IComponent.java
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/TestAbstractComponent.java
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/MockForm.java
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/services/impl/TestBindingSource.java
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/AbstractComponent.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/AbstractComponent.java?rev=279874&r1=279873&r2=279874&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/AbstractComponent.java
(original)
+++
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/AbstractComponent.java
Fri Sep 9 13:48:44 2005
@@ -837,16 +837,6 @@
return getMessages().format(key, argument1, argument2, argument3);
}
- /**
- * Returns this component.
- *
- * @since 4.0
- */
- public final IComponent getComponent()
- {
- return this;
- }
-
/** @since 4.0 */
public final IContainedComponent getContainedComponent()
{
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IComponent.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IComponent.java?rev=279874&r1=279873&r2=279874&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IComponent.java
(original)
+++
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/IComponent.java
Fri Sep 9 13:48:44 2005
@@ -340,32 +340,6 @@
public String getMessage(String key);
/**
- * Returns this component. That seems to be a very odd method for a
component; it's based on the
- * future direction of Tapestry. Currently, the base classes (such as
[EMAIL PROTECTED] AbstractComponent},
- * [EMAIL PROTECTED] BaseComponent} and [EMAIL PROTECTED]
org.apache.tapestry.html.BasePage}) largely provide
- * <em>structural concerns</em> such as containing, lifecycle, templates,
bindings, and so
- * forth. Tapestry users provide subclasses that represent the
<em>application concerns</em>:
- * properties, (listener) methods and parameters.
- * <p>
- * This current vision for Tapestry is to split these two concerns into
the component and
- * <em>the peer</em>. The peer contains the application concerns, the
component provides the
- * structural concerns. The peer will not have to implement any special
interfaces or subclass
- * from any special base classes (though there will be some optional
interfaces, annotations
- * and/or naming conventions). The component will be <em>injected</em>
into the peer as this
- * property: <code>component</code>.
- * <p>
- * That means that certain OGNL expression will have to change: For
example, "ognl:assets.foo"
- * may eventually have to be re-written as "ognl:component.assets.foo". Of
course, using
- * "asset:foo", or injecting the foo asset as a property, may make it even
easier to reference
- * the asset. In any case, having this property in place long before the
transition should make
- * it easier to build applications that can survive the transition
unchanged.`
- *
- * @since 4.0
- */
-
- public IComponent getComponent();
-
- /**
* Returns the [EMAIL PROTECTED]
org.apache.tapestry.spec.IContainedComponent}. This will be null for
* pages. This property is set when a component is constructed, and links
the component instance
* to the reference in the containing page or component's template or
specification. This is
Modified:
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/TestAbstractComponent.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/TestAbstractComponent.java?rev=279874&r1=279873&r2=279874&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/TestAbstractComponent.java
(original)
+++
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/TestAbstractComponent.java
Fri Sep 9 13:48:44 2005
@@ -36,13 +36,6 @@
}
- public void testGetComponent()
- {
- IComponent component = new ConcreteComponent();
-
- assertSame(component, component.getComponent());
- }
-
public void testUnimplementedMethods()
{
IComponent component = new ConcreteComponent();
Modified:
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/MockForm.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/MockForm.java?rev=279874&r1=279873&r2=279874&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/MockForm.java
(original)
+++
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/MockForm.java
Fri Sep 9 13:48:44 2005
@@ -340,11 +340,6 @@
_focus = focus;
}
- public IComponent getComponent()
- {
- return this;
- }
-
public IContainedComponent getContainedComponent()
{
return null;
Modified:
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/services/impl/TestBindingSource.java
URL:
http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/services/impl/TestBindingSource.java?rev=279874&r1=279873&r2=279874&view=diff
==============================================================================
---
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/services/impl/TestBindingSource.java
(original)
+++
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/services/impl/TestBindingSource.java
Fri Sep 9 13:48:44 2005
@@ -22,7 +22,6 @@
import org.apache.tapestry.IComponent;
import org.apache.tapestry.binding.BindingConstants;
import org.apache.tapestry.binding.BindingFactory;
-import org.easymock.MockControl;
/**
* Tests for [EMAIL PROTECTED]
org.apache.tapestry.services.impl.BindingSourceImpl}.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
