Author: jkuhnert Date: Sat Mar 18 06:41:13 2006 New Revision: 386853 URL: http://svn.apache.org/viewcvs?rev=386853&view=rev Log: Cleaning up checkstyle
Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DefaultParserDelegate.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObject.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObjectImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObjectTranslator.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DisableCachingFilter.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineFactoryImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineManagerImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceContribution.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceInnerProxy.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceObjectProvider.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceOuterProxy.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceSource.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExpressionCacheImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExpressionEvaluatorImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExtensionLookupFactory.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExtensionLookupParameter.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ImplMessages.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ImplStrings.properties jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureContribution.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureObjectProvider.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InitializationParameterHolderPropertySource.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InjectedValueProviderFactory.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InjectedValueProviderImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InvokeEngineTerminator.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LinkFactoryImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LocalizedPropertySource.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LocalizedStringRender.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/PropertyAccessorContribution.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/RequestGlobalsImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/RequestLocaleManagerImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ResourceLocalization.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ServiceEncoderContribution.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ServiceMapImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SetupRequestEncoding.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SetupServletApplicationGlobals.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SpecificationSourceImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SymbolSourcesPropertySourceFactory.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/TemplateSourceImpl.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/WebContextInitializer.java jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/WebRequestServicerPipelineBridge.java Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DefaultParserDelegate.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DefaultParserDelegate.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DefaultParserDelegate.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DefaultParserDelegate.java Sat Mar 18 06:41:13 2006 @@ -78,4 +78,4 @@ { return _componentAttributeName; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObject.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObject.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObject.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObject.java Sat Mar 18 06:41:13 2006 @@ -30,6 +30,6 @@ /** * Returns the target object. The caller is expected to cache the result, if appropriate. */ - public Object getObject(); + Object getObject(); -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObjectImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObjectImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObjectImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObjectImpl.java Sat Mar 18 06:41:13 2006 @@ -64,4 +64,4 @@ { return _location; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObjectTranslator.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObjectTranslator.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObjectTranslator.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DeferredObjectTranslator.java Sat Mar 18 06:41:13 2006 @@ -42,4 +42,4 @@ { _objectTranslator = objectTranslator; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DisableCachingFilter.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DisableCachingFilter.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DisableCachingFilter.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/DisableCachingFilter.java Sat Mar 18 06:41:13 2006 @@ -75,4 +75,4 @@ { _errorLog = errorLog; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineFactoryImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineFactoryImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineFactoryImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineFactoryImpl.java Sat Mar 18 06:41:13 2006 @@ -44,6 +44,10 @@ private ErrorLog _errorLog; + /** + * Creates a new engine? + * @author Howard Lewis Ship + */ interface EngineConstructor { IEngine construct(); @@ -53,6 +57,9 @@ // instantiate a BaseEngine instance, without using reflection // (for efficiency). + /** + * Creates a new reflective engine constructor. + */ static class ReflectiveEngineConstructor implements EngineConstructor { private Class _engineClass; Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineManagerImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineManagerImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineManagerImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineManagerImpl.java Sat Mar 18 06:41:13 2006 @@ -19,8 +19,8 @@ import org.apache.tapestry.IEngine; import org.apache.tapestry.services.EngineFactory; import org.apache.tapestry.services.EngineManager; -import org.apache.tapestry.services.RequestLocaleManager; import org.apache.tapestry.services.ObjectPool; +import org.apache.tapestry.services.RequestLocaleManager; /** * Implementation of service [EMAIL PROTECTED] org.apache.tapestry.services.EngineManager}. @@ -72,4 +72,4 @@ { _localeManager = manager; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceContribution.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceContribution.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceContribution.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceContribution.java Sat Mar 18 06:41:13 2006 @@ -49,4 +49,4 @@ { _service = service; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceInnerProxy.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceInnerProxy.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceInnerProxy.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceInnerProxy.java Sat Mar 18 06:41:13 2006 @@ -82,4 +82,4 @@ return _serviceName; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceObjectProvider.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceObjectProvider.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceObjectProvider.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceObjectProvider.java Sat Mar 18 06:41:13 2006 @@ -40,4 +40,4 @@ { return _serviceMap.getService(locator); } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceOuterProxy.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceOuterProxy.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceOuterProxy.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceOuterProxy.java Sat Mar 18 06:41:13 2006 @@ -35,6 +35,12 @@ */ public class EngineServiceOuterProxy implements IEngineService, Serializable { + + /** + * generated. + */ + private static final long serialVersionUID = 2050789495671401625L; + private final String _serviceName; private IEngineService _delegate; @@ -76,4 +82,4 @@ return ImplMessages.engineServiceOuterProxyToString(_serviceName); } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceSource.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceSource.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceSource.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/EngineServiceSource.java Sat Mar 18 06:41:13 2006 @@ -29,5 +29,5 @@ * Obtains an actual service implementation, not a proxy. */ - public IEngineService resolveEngineService(String name); -} \ No newline at end of file + IEngineService resolveEngineService(String name); +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExpressionCacheImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExpressionCacheImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExpressionCacheImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExpressionCacheImpl.java Sat Mar 18 06:41:13 2006 @@ -81,4 +81,4 @@ _serviceId = serviceId; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExpressionEvaluatorImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExpressionEvaluatorImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExpressionEvaluatorImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExpressionEvaluatorImpl.java Sat Mar 18 06:41:13 2006 @@ -153,4 +153,4 @@ { _contributions = contributions; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExtensionLookupFactory.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExtensionLookupFactory.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExtensionLookupFactory.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExtensionLookupFactory.java Sat Mar 18 06:41:13 2006 @@ -74,4 +74,4 @@ _specification = specification; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExtensionLookupParameter.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExtensionLookupParameter.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExtensionLookupParameter.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ExtensionLookupParameter.java Sat Mar 18 06:41:13 2006 @@ -25,9 +25,9 @@ */ public class ExtensionLookupParameter extends BaseLocatable { - private String _extensionName; + private String _extensionName; private Object _default; - + public String getExtensionName() { return _extensionName; Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ImplMessages.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ImplMessages.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ImplMessages.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ImplMessages.java Sat Mar 18 06:41:13 2006 @@ -38,10 +38,13 @@ * @author Howard Lewis Ship * @since 4.0 */ -class ImplMessages +final class ImplMessages { - private final static MessageFormatter _formatter = new MessageFormatter(ImplMessages.class); + private static final MessageFormatter _formatter = new MessageFormatter(ImplMessages.class); + /* defeat instantiation */ + private ImplMessages() { } + static String initializerContribution() { return _formatter.getMessage("initializer-contribution"); @@ -279,4 +282,4 @@ { return _formatter.getMessage("service-name-is-null"); } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ImplStrings.properties URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ImplStrings.properties?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ImplStrings.properties (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ImplStrings.properties Sat Mar 18 06:41:13 2006 @@ -61,4 +61,4 @@ missing-infrastructure-property=Infrastructure property ''{0}'' is not defined. used-template-parameter-alias=Parameter {2} (for component {1}, at {0}) was bound; this parameter has been deprecated, bind parameter {3} instead. engine-class-not-found=Engine class ''{0}'' not found. -service-name-is-null=The service name is null. Engine services must implement method getServiceName() and return a non-null value. \ No newline at end of file +service-name-is-null=The service name is null. Engine services must implement method getServiceName() and return a non-null value. Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureContribution.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureContribution.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureContribution.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureContribution.java Sat Mar 18 06:41:13 2006 @@ -95,4 +95,4 @@ return _mode != null && _mode.equals(mode); } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureImpl.java Sat Mar 18 06:41:13 2006 @@ -401,4 +401,4 @@ { _errorLog = errorLog; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureObjectProvider.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureObjectProvider.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureObjectProvider.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InfrastructureObjectProvider.java Sat Mar 18 06:41:13 2006 @@ -85,4 +85,4 @@ _infrastructure = infrastructure; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InitializationParameterHolderPropertySource.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InitializationParameterHolderPropertySource.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InitializationParameterHolderPropertySource.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InitializationParameterHolderPropertySource.java Sat Mar 18 06:41:13 2006 @@ -38,4 +38,4 @@ _holder = holder; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InjectedValueProviderFactory.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InjectedValueProviderFactory.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InjectedValueProviderFactory.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InjectedValueProviderFactory.java Sat Mar 18 06:41:13 2006 @@ -41,4 +41,4 @@ { _objectTranslator = objectTranslator; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InjectedValueProviderImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InjectedValueProviderImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InjectedValueProviderImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InjectedValueProviderImpl.java Sat Mar 18 06:41:13 2006 @@ -30,17 +30,22 @@ private Translator _objectTranslator; /** - * Deletegates out to - * [EMAIL PROTECTED] Translator#translate(org.apache.hivemind.internal.Module, java.lang.Class, java.lang.String, org.apache.hivemind.Location) + * Creates a new value provider. + * @param module + * @param objectTranslator */ - public Object obtainValue(String locator, Location location) - { - return _objectTranslator.translate(_module, Object.class, locator, location); - } - public InjectedValueProviderImpl(Module module, Translator objectTranslator) { _module = module; _objectTranslator = objectTranslator; } -} \ No newline at end of file + + /** + * Deletegates out to + * [EMAIL PROTECTED] Translator#translate(org.apache.hivemind.internal.Module, java.lang.Class, java.lang.String, org.apache.hivemind.Location). + */ + public Object obtainValue(String locator, Location location) + { + return _objectTranslator.translate(_module, Object.class, locator, location); + } +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InvokeEngineTerminator.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InvokeEngineTerminator.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InvokeEngineTerminator.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/InvokeEngineTerminator.java Sat Mar 18 06:41:13 2006 @@ -31,7 +31,7 @@ * <ul> * <li>Storing the request and response into [EMAIL PROTECTED] org.apache.tapestry.services.RequestGlobals}. * <li>Locating the correct engine instance and letting it to the rest of the request. - * <li>Returning the engine instance to the pool at the end of the request. </ul + * <li>Returning the engine instance to the pool at the end of the request. </ul> * * @author Howard Lewis Ship * @since 4.0 @@ -80,4 +80,4 @@ { _requestGlobals = requestGlobals; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LinkFactoryImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LinkFactoryImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LinkFactoryImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LinkFactoryImpl.java Sat Mar 18 06:41:13 2006 @@ -60,7 +60,7 @@ private String _servletPath; - private final Object[] EMPTY = new Object[0]; + private final Object[] _empty = new Object[0]; private URLCodec _codec = new URLCodec(); @@ -174,7 +174,7 @@ String[] squeezed = cycle.getParameters(ServiceConstants.PARAMETER); if (Tapestry.size(squeezed) == 0) - return EMPTY; + return _empty; try { @@ -245,4 +245,4 @@ { _requestCycle = requestCycle; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LocalizedPropertySource.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LocalizedPropertySource.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LocalizedPropertySource.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LocalizedPropertySource.java Sat Mar 18 06:41:13 2006 @@ -69,4 +69,4 @@ return null; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LocalizedStringRender.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LocalizedStringRender.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LocalizedStringRender.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/LocalizedStringRender.java Sat Mar 18 06:41:13 2006 @@ -93,4 +93,4 @@ return builder.toString(); } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/PropertyAccessorContribution.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/PropertyAccessorContribution.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/PropertyAccessorContribution.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/PropertyAccessorContribution.java Sat Mar 18 06:41:13 2006 @@ -14,10 +14,10 @@ package org.apache.tapestry.services.impl; -import org.apache.hivemind.impl.BaseLocatable; - import ognl.PropertyAccessor; +import org.apache.hivemind.impl.BaseLocatable; + /** * A contribution to the <code>tapestry.ognl.PropertyAccessors</code> configuration point; this * provides the Class and [EMAIL PROTECTED] ognl.PropertyAccessor}that will be passed to @@ -51,4 +51,4 @@ { _subjectClass = subjectClass; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/RequestGlobalsImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/RequestGlobalsImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/RequestGlobalsImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/RequestGlobalsImpl.java Sat Mar 18 06:41:13 2006 @@ -82,4 +82,4 @@ { _requestCycle = cycle; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/RequestLocaleManagerImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/RequestLocaleManagerImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/RequestLocaleManagerImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/RequestLocaleManagerImpl.java Sat Mar 18 06:41:13 2006 @@ -194,4 +194,4 @@ { _acceptedLocales = acceptedLocales; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ResourceLocalization.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ResourceLocalization.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ResourceLocalization.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ResourceLocalization.java Sat Mar 18 06:41:13 2006 @@ -47,4 +47,4 @@ { return _resource; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ServiceEncoderContribution.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ServiceEncoderContribution.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ServiceEncoderContribution.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ServiceEncoderContribution.java Sat Mar 18 06:41:13 2006 @@ -30,6 +30,10 @@ private String _before; + private String _after; + + private ServiceEncoder _encoder; + public String getAfter() { return _after; @@ -69,8 +73,4 @@ { _id = id; } - - private String _after; - - private ServiceEncoder _encoder; -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ServiceMapImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ServiceMapImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ServiceMapImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/ServiceMapImpl.java Sat Mar 18 06:41:13 2006 @@ -25,7 +25,7 @@ import org.apache.tapestry.services.ServiceMap; /** - * Implementation of [EMAIL PROTECTED] org.apache.tapestry.services.ServiceMap} + * Implementation of [EMAIL PROTECTED] org.apache.tapestry.services.ServiceMap}. * * @author Howard Lewis Ship * @since 4.0 @@ -165,4 +165,4 @@ { _errorLog = errorLog; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SetupRequestEncoding.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SetupRequestEncoding.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SetupRequestEncoding.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SetupRequestEncoding.java Sat Mar 18 06:41:13 2006 @@ -82,4 +82,4 @@ { _outputEncoding = outputEncoding; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SetupServletApplicationGlobals.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SetupServletApplicationGlobals.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SetupServletApplicationGlobals.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SetupServletApplicationGlobals.java Sat Mar 18 06:41:13 2006 @@ -39,4 +39,4 @@ initialize(mode == null ? "servlet" : mode); } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SpecificationSourceImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SpecificationSourceImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SpecificationSourceImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SpecificationSourceImpl.java Sat Mar 18 06:41:13 2006 @@ -256,4 +256,4 @@ _serviceId = serviceId; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SymbolSourcesPropertySourceFactory.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SymbolSourcesPropertySourceFactory.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SymbolSourcesPropertySourceFactory.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/SymbolSourcesPropertySourceFactory.java Sat Mar 18 06:41:13 2006 @@ -34,4 +34,4 @@ return new SymbolSourcesPropertySource(parameters.getInvokingModule()); } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/TemplateSourceImpl.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/TemplateSourceImpl.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/TemplateSourceImpl.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/TemplateSourceImpl.java Sat Mar 18 06:41:13 2006 @@ -60,15 +60,18 @@ public class TemplateSourceImpl implements TemplateSource, ResetEventListener, ReportStatusListener { - private String _serviceId; - - private Log _log; // The name of the component/application/etc property that will be used to // determine the encoding to use when loading the template public static final String TEMPLATE_ENCODING_PROPERTY_NAME = "org.apache.tapestry.template-encoding"; + private static final int BUFFER_SIZE = 2000; + + private String _serviceId; + + private Log _log; + // Cache of previously retrieved templates. Key is a multi-key of // specification resource path and locale (local may be null), value // is the ComponentTemplate. @@ -80,8 +83,6 @@ private Map _templates = Collections.synchronizedMap(new HashMap()); - private static final int BUFFER_SIZE = 2000; - private ITemplateParser _parser; /** @since 2.2 */ @@ -577,4 +578,4 @@ { _localizer = localizer; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/WebContextInitializer.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/WebContextInitializer.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/WebContextInitializer.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/WebContextInitializer.java Sat Mar 18 06:41:13 2006 @@ -46,4 +46,4 @@ { _globals = globals; } -} \ No newline at end of file +} Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/WebRequestServicerPipelineBridge.java URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/WebRequestServicerPipelineBridge.java?rev=386853&r1=386852&r2=386853&view=diff ============================================================================== --- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/WebRequestServicerPipelineBridge.java (original) +++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/services/impl/WebRequestServicerPipelineBridge.java Sat Mar 18 06:41:13 2006 @@ -70,4 +70,4 @@ { _webRequestServicer = webRequestServicer; } -} \ No newline at end of file +} --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]