[ http://issues.apache.org/jira/browse/TAPESTRY-368?page=all ]
     
Paul Ferraro reopened TAPESTRY-368:
-----------------------------------

     Assign To:     (was: Jesse Kuhnert)

This fix is not correct.

If I have the following in my hivemodule.xml:

        <service-point id="MultipartDecoder">
                <create-instance 
class="org.apache.tapestry.multipart.MultipartDecoderImpl,maxSize=-1" 
model="threaded"></create-instance>
        </service-point>

then I would expect the Upload component to respect the maxSize value of -1.
However, line 89 of Upload.java:

        getDecoder().setSizeMax(getMaxSize());

sets the maxSize to the value of the Upload component's maxSize parameter (i.e. 
10000000, by default).

Consequently, when the uploaded file is processed, the MultipartDecoderImpl 
will use 10000000 instead of -1.

Until this is addressed, I'm reopening this issue.

> Please add setMaxSize to MultipartDecoder
> -----------------------------------------
>
>          Key: TAPESTRY-368
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-368
>      Project: Tapestry
>         Type: New Feature
>   Components: Framework
>     Versions: 4.0
>     Reporter: Gavin Mathias
>     Priority: Minor
>      Fix For: 4.0.1
>  Attachments: tap368.txt
>
> I use the Upload component to upload files to my application. Most of those 
> files are over the size limit of 10000000 hardcoded in MultipartDecoderImpl. 
> Please add setMaxSize(int  _maxsize) to MultipartDecoder so that I can write 
> a custom Upload component that can do this:
> getDecoder().setMaxSize(30000000);
> Even nicer would be a parameter in Tapestry's Upload.jwc that can be used to 
> set MaxSize.
> I was doing this in Tapestry3.0.3 by calling:
> DefaultMultipartDecoder.getSharedInstance().setMaxSize(30000000);
> in my custom component's page class.
> Thanks and Best Regards,
> Gavin

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to