[ http://issues.apache.org/jira/browse/TAPESTRY-339?page=all ] Brian K. Wallace closed TAPESTRY-339: -------------------------------------
> LinkSubmit can cause browser back button problems > ------------------------------------------------- > > Key: TAPESTRY-339 > URL: http://issues.apache.org/jira/browse/TAPESTRY-339 > Project: Tapestry > Type: Bug > Versions: 3.0.3 > Environment: Any > Reporter: Nick Westgate > Assignee: Jesse Kuhnert > Priority: Minor > Fix For: 3.0.4 > > If LinkSubmit is mixed with other submit components in the same form, > erroneous submits can occur from pages accessed via the browser back button. > This happens because LinkSubmit's hidden variable is never reset. > Suggested fix (line marked +++) in LinkSubmit.java, renderComponent method: > // make sure the submit function is on the page (once) > if (cycle.getAttribute(ATTRIBUTE_FUNCTION_NAME) == null) > { > +++ body.addInitializationScript("document." + formName + > "._linkSubmit.value = null;"); > body.addBodyScript( > "function submitLink(form, elementId) { > form._linkSubmit.value = elementId; if (form.onsubmit == null || > form.onsubmit()) form.submit(); }"); > cycle.setAttribute(ATTRIBUTE_FUNCTION_NAME, this); > } > It would be great if the corrected LinkSubmit submission mechanism detail was > factored out into a separate class, so that other submit components could be > built using it. For example, Glen Stampoultzis's ButtonSubmit component. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
