Hi Ben!

That makes more sense. I didn't look into the code deep enough. I see that
PageRenderListener implements both PageBeginRenderListener and
PageEndRenderListener. Since PageRenderListener is deprecated, it does seem
like the pageEndRender in AbstractComponent should be deprecated as well.
There are a couple of places in our code where we had pageEndRender methods
that we thought were being used, but apparently weren't. I can show you if
you're interested.

-Chris

On 11/8/05, Ben Dotte <[EMAIL PROTECTED]> wrote:
>
> My assumption would be backwards compatibility. The comment in
> AbstractComponent says it's there for classes that implement
> PageRenderListener and only need the pageBeginRender method from it. Now
> that that has been split out to PageBeginRenderListener and
> PageEndRenderListener the method is no longer needed, except for any
> pages that might still implement PageRenderListener. Seems like it
> should be marked as deprecated in 4.0 and removed in 4.1 maybe?
>
> Ben
>
> -----Original Message-----
> From: Chris Norris [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, November 08, 2005 11:22 AM
> To: Tapestry users
> Subject: Re: AbstractComponent's pageEndRender method
>
> John,
> Thanks for the reply. I know when it is used. I was just wondering what
> the
> purpose of leaving pageEndRender in AbstractComponent is. It seems like
> it's
> entirely unused and could therefore only serve to be confusing to some
> people.
>
>
>
> On 11/8/05, Prince John, Bedag <[EMAIL PROTECTED]> wrote:
> >
> > Hi,
> >
> > None of the standard Tapestry classes implement PageEndRenderListener
> so
> > you need to implement it yourself in your class if you want the
> listener
> > to be called. According to the docs, it is used to cleanup resources
> > that are only needed during the render. In Eclipse you can see if you
> > are overriding, or implementing, a method from the icon to the left of
> > the method declaration.
> >
> > Best wishes
> >
> > John
> >
> > -----Original Message-----
> > From: Chris Norris [mailto:[EMAIL PROTECTED]
> > Sent: Tuesday, November 08, 2005 6:07 PM
> > To: Tapestry users
> > Subject: AbstractComponent's pageEndRender method
> >
> >
> > Is this ever use anywhere? I wanted to implement a pageEndRender
> method
> > on a page. I thought that a superclass of the page's class implement
> > PageEndRenderListener, so I checked to see if I could override
> > pageEndRender. I'm using Eclipse, so it showed that I had that method
> to
> > override. I did and nothing happened. This is because I was overriding
> > AbstractComponent's pageEndRender method. What is this method there
> for?
> > As far as I can tell, it's never used by the framework.
> >
> > -Chris
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

Reply via email to