Whoops, I just noticed I didn’t send this last Tuesday! I would have let it drop as out-of-date, but I still wanted to say thanks to Philipp for the review and suggestion.
Hi Philipp, Thanks for taking a look, and for the suggestion. I agree that seems nicer, so I updated the model and the input .json files to match, and adjusted the import logic so it runs again. I also cleaned up the transport-properties in that repo to match (I think) with the latest text from section 5.2 of taps-interface. - Jake From: "Philipp S. Tiesel" <[email protected]> Date: 2019-05-07 at 01:46 To: Jake Holland <[email protected]> Cc: "Brian Trammell (IETF)" <[email protected]>, Aaron Falk <[email protected]>, "[email protected]" <[email protected]> Subject: YANG model for TAPS (was: Re: [Taps] Transport Services (taps) WG Virtual Meeting: 2019-05-08) Hi Jake, thanks on your work on PyTAPS and the YANG model! I love the idea of having a implementation-agnostic way to specify endpoints and transport properties. I have not reviewed the work on PyTAPS yet, but have some comments on the updated YANG model. It is far better than the first version, especially with regards to the endpoint definition. With regards to the properties, I think the modelling of transport properties still does not work as the transport properties in the draft. The transport properties in the YANG model model only a subset of the selection properties. For the actual preferences, I’d rather expected something like: container transport-properties { leaf reliability { description "Reliable Transport"; type preference-level; } leaf per-message-reliability { description "Per-message Reliable Transport"; type preference-level; } leaf preserve-order { description "Per-message Reliable Transport"; type preference-level; } leaf zero-rtt-establishment { description "Use 0-RTT session establishment with an idempotent Message"; type preference-level; } list iftype { leaf type { when "derived-from-or-self(../type, 'taps:local-interface-selection')"; type identityref { base "ianaift:iana-interface-type"; } } leaf preference { type preference-level; } description "interface type constraint for local interface selection"; reference "RFC 7224 Section 2"; } But maybe we should discuss details off-line…
_______________________________________________ Taps mailing list [email protected] https://www.ietf.org/mailman/listinfo/taps
