* Dmitry Simonenko <[email protected]> [12/06/14 18:35]:
>   Branch: refs/heads/connector-c-librpl
>   Home:   https://github.com/mailru/tarantool
>   Commit: ed47b70d7db4b9bf9a1e0b38324d822f1017d835
>       
> https://github.com/mailru/tarantool/commit/ed47b70d7db4b9bf9a1e0b38324d822f1017d835
>   Author: Dmitry Simonenko <[email protected]>
>   Date:   2012-06-14 (Thu, 14 Jun 2012)

Hello Dmitry,

I've pushed this into the master.

A few remaining comments:
- it would be nice to explain what you're actually doing in the
test case (why you restart the servers with different
configuration and so on).
- you should update the command line client manual and, ideally,
the user guide, and show what can be done with the new command
line client
- your tests don't seem to test marshalling of a sequence of
  events, or I'm wrong?
- I added unit/unit.h which contains stuff like fail_unless()
which is pretty much the same as TT_ASSERT. Let's think about
merging the two.

Thank you for working on this patch!

-- 
http://tarantool.org - an efficient, extensible in-memory data store

_______________________________________________
Mailing list: https://launchpad.net/~tarantool-developers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~tarantool-developers
More help   : https://help.launchpad.net/ListHelp

Reply via email to