Branch: refs/heads/tuple-access
Home: https://github.com/mailru/tarantool
Commit: af4164fb0e5f69d4107364c6cc7fd1862e00572b
https://github.com/mailru/tarantool/commit/af4164fb0e5f69d4107364c6cc7fd1862e00572b
Author: Konstantin Osipov <[email protected]>
Date: 2013-06-18 (Tue, 18 Jun 2013)
Changed paths:
M cmake/compiler.cmake
M src/box/bitset_index.cc
M src/box/box_lua.cc
M src/box/space.cc
M src/box/tuple.cc
M src/box/tuple.h
M src/memcached-grammar.cc
M src/memcached-grammar.rl
M src/memcached.cc
Log Message:
-----------
tuple-access: code review fixes
Two significant changes (both arguable, since this patch is about
taste by a large measure):
1) Split tuple_seek() into two: tuple_rewind()
and tuple_seek().
tuple_rewind() simply initializes the iterator and
sets it to 'before-first' position.
tuple_seek() returns a field, and sets the iterator
to the position after the returned field.
Previosly there was only tuple_seek(), which required
tuple_next() to get the field, and it was confusing whether
or not tuple_next() after tuple_seek() is required.
Indeed, the very code I chagned sometimes would
call tuple_next() after tuple_seek() and sometimes would not.
2) Move the return value of the iterator outside
of iteration state.
The advantage of "binding" the out parameters of the iterator to
iterator state is that you bind once, and don't need to supply out
parameters into every call to tuple_next() function. It also makes
it easy to add extra out parameters for bind in the future (field
data type, flags, etc).
This makes "binding" technique popular in database driver
APIs. Binding makes API more stable, which is also
important in drivers.
In this case, however, binding adds for extra lines of code
and (possibly) few extra instructions. Plus, since
this is an internal API which we can change any day,
its stability is not as important. So it seems that for
now we're better of with an API which is a bit
more concise/efficient, and can switch to using binding later,
if needed.
_______________________________________________
Mailing list: https://launchpad.net/~tarantool-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~tarantool-developers
More help : https://help.launchpad.net/ListHelp
