confetti code generator is broken in other ways (compilation warnings,
etc). and is not worth bothering with.
** Changed in: tarantool
Status: New => Won't Fix
--
You received this bug notification because you are a member of Tarantool
Development Team, which is subscribed to tarantool.
https://bugs.launchpad.net/bugs/1130852
Title:
Config parser is broken if char is unsigned (-funsigned-char)
Status in Tarantool - an efficient in-memory data store:
Won't Fix
Bug description:
CFLAGS="-funsigned-char" cmake .
tarantool/unsigned-char-fix/cfg/tarantool_box_cfg.c: In function
‘tarantool_cfg_iterator_next’:
tarantool/unsigned-char-fix/cfg/tarantool_box_cfg.c:1703:7: error: comparison
is always false due to limited range of data type [-Werror=type-limits]
tarantool/unsigned-char-fix/cfg/tarantool_box_cfg.c:1756:10: error:
comparison is always false due to limited range of data type
[-Werror=type-limits]
tarantool/unsigned-char-fix/cfg/tarantool_box_cfg.c: In function
‘check_cfg_tarantool_cfg’:
tarantool/unsigned-char-fix/cfg/tarantool_box_cfg.c:1839:4: error: comparison
is always false due to limited range of data type [-Werror=type-limits]
tarantool/unsigned-char-fix/cfg/tarantool_box_cfg.c:1863:6: error: comparison
is always false due to limited range of data type [-Werror=type-limits]
tarantool/unsigned-char-fix/src/box/space.m: In function ‘check_spaces’:
tarantool/unsigned-char-fix/src/box/space.m:513:4: error: comparison is
always false due to limited range of data type [-Werror=type-limits]
"c->space[i->idx_name__space]->enabled == -1" where
typeof(c->space[i->idx_name__space]->enabled) is char
(tests crash)
The problem exists both in our code (e.g. space.m) and in confetti.
Fix is trivial - just use 'CHAR_MAX' instead of '-1' in all places OR add a
cast.
Of course, we can just force '-fsigned-char' compilation flag, but I prefer
to fix the code.
To manage notifications about this bug go to:
https://bugs.launchpad.net/tarantool/+bug/1130852/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~tarantool-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~tarantool-developers
More help : https://help.launchpad.net/ListHelp
